owid / etl

A compute graph for loading and transforming OWID's data
https://docs.owid.io/projects/etl
MIT License
58 stars 18 forks source link

`chart-sync` fails when user renames variables #2871

Closed Marigold closed 5 days ago

Marigold commented 1 week ago

If someone renames short name of a variable, e.g. from dummy_a to dummy_b and modifies a chart which uses that variable, then ETL deploy will fail after merging the staging server. The way ETL works is that it adds variable dummy_b and then tries to remove unused variable dummy_a. The problem is that the chart hasn't been synced yet and still depends on dummy_a, hence cannot be deleted and ETL fails with the error message

ValueError: Variables used in charts will not be deleted automatically:

I don't have a good solution, but here are some options:

Marigold commented 5 days ago

Fixed by https://github.com/owid/etl/pull/2890