owid / etl

A compute graph for loading and transforming OWID's data
https://docs.owid.io/projects/etl
MIT License
58 stars 18 forks source link

:sparkles: Add roundingMode to variable.display in YAML #2897

Closed Marigold closed 4 days ago

Marigold commented 4 days ago

@sophiamersmann it actually worked out of the box. I checked this example and the values are in metadata JSON. Is that all we have to do?

TODO before merging

owidbot commented 4 days ago
Quick links (staging server): Site Admin Wizard

Login: ssh owid@staging-site-rounding-mode

chart-diff: ✅ No charts for review.
data-diff: ❌ Found differences ```diff = Dataset garden/biodiversity/2024-01-25/cherry_blossom = Table cherry_blossom ~ Column full_flowering_date (changed metadata) + + numSignificantFigures: 3 + + roundingMode: significantFigures Legend: +New ~Modified -Removed =Identical Details Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet ``` Automatically updated datasets matching _weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk_ are not included

Edited: 2024-06-26 10:27:31 UTC Execution time: 13.54 seconds

Marigold commented 4 days ago

ps: What does the pattern <% mean? (Just wondering if I forgot to implement something)

That's ETL thing. Sometimes we use dynamic Jinja templates in metadata with <% tags so we allow it in JSONschema too.