🐛 indicator-upgrader: team feedback

[lucasrodes]

Errors found

• [x] ValueError: caused by not finding a key in st.session_state.indicator_upgrades_ignore. (first image). It worked fine after refresh. Refreshing is fine for a small dataset, but not great if user has done substantial work already. After selecting some indicators from dropdowns, the user went to select another one and this error was raised.
• [ ] A user reported weird charts appearing in chart-diff. After looking into them, they seem to originate from updating the referenced indicator IDs in the chart config via the indicator upgrader. Unclear if it was due to a human mistake or some logic in indicator-upgrader failed. UNCLEAR FOR NOW ー TO EXPLORE IF IT IS REPORTED AGAIN

[owidbot]

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-bugs-indicator-upgrader

chart-diff: ✅

No charts for review.

data-diff: ✅ No differences found

```diff Legend: +New ~Modified -Removed =Identical Details Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet ``` Automatically updated datasets matching _weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk_ are not included

Edited: 2024-06-26 15:10:18 UTC Execution time: 13.19 seconds

[lucasrodes]

I was able to reproduce the first error. It seems to occur when you click the first 'next' button for the second time.

Seems that the session_state might not be properly configured.

https://github.com/owid/etl/assets/18101289/0a36da3f-daa1-4c59-a5df-44c0a715b99c