owid / etl

A compute graph for loading and transforming OWID's data
https://docs.owid.io/projects/etl
MIT License
78 stars 21 forks source link

wizard: Issues and improvements for Map Bracketer #2915

Closed pabloarosado closed 2 weeks ago

pabloarosado commented 3 months ago

One-liner

Add comments for any issue you find or any suggestion you have for Map Bracketer.

paarriagadap commented 3 months ago

Hi! Looks very cool! For now, I have found that when I save one indicator configuration it deletes the content of explorerSubtitle. I tried with the air-pollution explorer and indicator 900429:

EDIT: Ah, now I see it's because it has this parameter twice:

image
pabloarosado commented 3 months ago

Thanks @paarriagadap ! It looks like that explorer has two entries for "explorerSubtitle", which should not happen (or is there any situation where that should be allowed?).

paarriagadap commented 3 months ago

@pabloarosado Yes, I found out and edited the post. No, I understand it should never be allowed.

lucasrodes commented 2 months ago

I was trying the tool for the new population and demography explorer (https://github.com/owid/etl/pull/2936). This new explorer, whose config is available in owid-content, branch unwpp-update, uses catalogPath instead of variableId.

The error, which is shown in the image below, seems to come from trying to set column colorScaleNumericMinValue as a float.

df["colorScaleNumericMinValue"] = df["colorScaleNumericMinValue"].astype(float)
image
stale[bot] commented 4 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.