search

owid / etl

A compute graph for loading and transforming OWID's data
https://docs.owid.io/projects/etl
MIT License
85 stars 23 forks source link

🐛 harmonize: Fix harmonize ipython when used on already harmonized datasets #3577

Closed pabloarosado closed 2 days ago

pabloarosado commented 2 days ago

Fixes https://github.com/owid/etl/issues/3559

I encountered the same issue and patched it quickly, I haven't looked thoroughly into it, but it worked for my case.

owidbot commented 2 days ago
Quick links (staging server): Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-fix-harmonize-ipython

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found ```diff Legend: +New ~Modified -Removed =Identical Details Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet ``` Automatically updated datasets matching _weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk_ are not included

Edited: 2024-11-20 13:42:25 UTC Execution time: 15.63 seconds

lucasrodes commented 2 days ago

@antea04 when you have time, could you try it out and see if it solves the issue for you, too?

pabloarosado commented 2 days ago

Thanks @lucasrodes, I'm not sure if the current behavior is what we'd want, but at least now harmonize_ipython can be used when all country names are already harmonized. We can revisit it later and tweak it again in a separate PR.