Closed danyx23 closed 6 months ago
This is not related to any recent change - it's also happening on playfair
(51712f2) and neurath
(1c7398f), which are both running on many-months-old changesets right now.
From a very first investigation, it looks like entityIds
are being dropped somewhere in the table transform, probably in interpolateColumnWithTolerance
.
Okay, so the good thing is that this is definitely not a new thing, but has probably been happening ever since Project Next. It's only happening for DiscreteBarCharts with tolerance, and only on the tolerance-induced entities.
The underlying problem is that CoreTable.complete([entityNameColumn, timeColumn])
doesn't include "related" columns like EntityId, EntityCode, EntityColor etc. for "newly-created" rows.
We have tracked this issue before, and there is an old closed PR for it.
You make Sherlock Holmes look like Regular Holmes! Great that you uncovered where this came from, that is already very helpful.
Marked it as "nice to have" since it hasn't emerged as a prio for authors, but @marcelgerber if you believe it would be a quick fix you're welcome to have a shot after your other tasks.
but @marcelgerber if you believe it would be a quick fix you're welcome to have a shot after your other tasks.
Definitely not an easy one, sadly!
Bumping it back down to "nice to have" since it hasn't caused us any issues in the meantime and no authors are banging down our door
This issue has had no activity within 10 months. It is considered stale and will be closed in 7 days unless it is worked on or tagged as pinned.
Description
When you have a distinct bar chart and you set an entity color in the data tab the corresponding bar should have this color but instead it doesn't change color FOR SOME BARS (!)
Expected behaviour
A bar with a manually assigned entity color should be drawn in that color
Steps to reproduce
Steps to reproduce the behavior:
Screenshots
Additional context
I was suspecting that I introduced this bug as part of the #1611 issue but the problem seems to predate this. Maybe it is related to the PR #1623?