owid / owid-grapher

A platform for creating interactive data visualizations
https://ourworldindata.org
MIT License
1.36k stars 228 forks source link

Grapher prominent link thumbnails aren't rendering #2870

Open ikesau opened 9 months ago

ikesau commented 9 months ago
{.prominent-link}
url: https://ourworldindata.org/grapher/life-expectancy
{}

Is resulting in image

And the following when baked (ignore the lack of Playfair Display 🙈) image

marcelgerber commented 8 months ago

Ah yes, in the transition to Cloudflare Pages we have moved these from https://ourworldindata.org/grapher/exports/life-expectancy.svg to the https://assets.ourworldindata.org domain (and same path). Wonder if that's related in any way?

ikesau commented 6 months ago

This would be relatively straightforward to fix, by handling grapher links as a special case in the prominent link code, around where it's deciding to use the result of useImage or not. We can do it when an author needs to prominent link to a grapher (which hasn't happened yet)