Open toni-sharpe opened 3 months ago
Hi @toni-sharpe - thanks for reporting this. We should fix this but it's not particularly urgent on our side. If you want to fix it along the lines of what the error message suggests then we'd be happy about a PR, otherwise we'll tackle it in some cooldown.
Well this wasn't as painful as I thought (at least, until someone whose got a broader view spots some lurking horror) - perhaps my poor ex-PM was the outlier.
Description
It looks like a bit of time is needed to get a few things up to date if possible, this error relies on that which needs this +2 now that is +2 as well, a few things, the full errors below.
One of those moments where pausing dealing with it is a good move IMO.
The failing code is a breaking change in Sass and to fix it, one has to upgrade to BootStrap 5.3.2 which is not playing ball.
Looks like there's some peer depedencies out of sync
This error is output
Expected behaviour
Steps to reproduce
npm i bootstrap@v5.3.2
Screenshots
Environment
TMux in iTerm2, and zsh Mac: M1 2020 Sonoma: 14.1.1
Additional context
There might be a general problem here of things slipping out of date, and be very painful if it gets out of hand. Errors suggesting forcing dependency and things I don't think I'd try at this stage, there's a lot going on.
"sass": "^1.69.5",
Sass seems to be 2 full versions behind? Maybe I'm wrong, I'm looking here.
React as well, looks like 19 is in beta, so that's slipping, and they're major components of the site build.
In my experience these things can suddenly tangle as XN.N drops support for Bootstrap 4 but won't run in it's old form in the latest browsers, causing a chain of major updates. I'll be honest, I have got away with this, but the PM at the last big project, he'd tried his luck and it went crunch. It's no fun fixing either!
I appreciate there could be some large blocker keping something React down, we got stuck Node 12 for ages like that at one point. But the honest reflection, we ought to have just done it sooner!
DX
We now have a panel with a lot of trivial text in, which is sent > that way and in among, TS errors, easier to miss, and now with a new starter it'll especially hard for them
Full error on BootStrap 5.3.2