✨ (stacked bar) move legend to the top on mobile

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

✨ (stacked bar) move legend to the top on mobile #3629

Closed sophiamersmann closed 3 weeks ago

sophiamersmann commented 1 month ago

Moves the legend of stacked bar charts to the top on mobile.

(SVG differences come from the previous PR)

If there is very little space (due to long text), then moving the legend to the top eats into the vertical space badly:

Before (375px)	After (375px)

Before (325px)	After (325px)

(Note that the legend overflows in the before version)

sophiamersmann commented 1 month ago

#3629 👈
#3622
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-discrete-bar-mobile-legend

Site-screenshots: https://github.com/owid/site-screenshots/compare/discrete-bar-mobile-legend
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/discrete-bar-mobile-legend

SVG tester:

Number of differences (default views): 19 ([a90d8f](https://github.com/owid/owid-grapher-svgs/commit/a90d8fa7fe63af4cd5365fb22e9f09d98620bcae)) ❌ Number of differences (all views): 100 ([c7314e](https://github.com/owid/owid-grapher-svgs/commit/c7314e9009c23b24af4d05afc88e3181416b73d1)) ❌

Edited: 2024-06-10 11:25:39 UTC Execution time: 1.19 seconds

sophiamersmann commented 3 weeks ago

Merge activity

Jun 10, 7:44 AM EDT: @sophiamersmann started a stack merge that includes this pull request via Graphite.
Jun 10, 7:47 AM EDT: Graphite rebased this pull request as part of a merge.
Jun 10, 7:49 AM EDT: Graphite rebased this pull request as part of a merge.
Jun 10, 7:51 AM EDT: @sophiamersmann merged this pull request with Graphite.