fix(baker): remove progress bar throttling

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

fix(baker): remove progress bar throttling #3632

Closed mlbrgl closed 1 month ago

mlbrgl commented 1 month ago

By default, the progress bar rendering is throttled at 16ms.

In our case, we don't want the rendering to be throttled (which happens when code executes faster than the throttle threshold), as every discrete step in the baking flow needs to be logged.

This PR effectively disables throttling for progress bars used in baking.

Incidentally, we were off by two at the end of baking (26/28), now off by one (27/28).

mlbrgl commented 1 month ago

#3633
#3632 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mlbrgl and the rest of your teammates on Graphite

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-remove-progress-bar-throttling

Site-screenshots: https://github.com/owid/site-screenshots/compare/remove-progress-bar-throttling
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/remove-progress-bar-throttling

SVG tester:

Number of differences (default views): 0 Number of differences (all views): 0

Edited: 2024-05-22 14:45:54 UTC Execution time: 1.23 seconds

mlbrgl commented 1 month ago

Merge activity

May 28, 5:09 AM EDT: @mlbrgl started a stack merge that includes this pull request via Graphite.
May 28, 5:10 AM EDT: Graphite rebased this pull request as part of a merge.
May 28, 5:10 AM EDT: @mlbrgl merged this pull request with Graphite.