garden: Improve TMux/make.up commands

toni-sharpe commented 1 month ago

if the TMux window is closed in some other way than Ctrl+b, Q then make up will error, throwing duplicate session - this change checks for a session and removes the grapher session if it's found before going back to where the contributor was.
This also happens if master is updated on a fork and make up is re-run to bring things up to date.

Thinking from the perspective of an open source contributor, perhaps with less experience, and wanting to make things like TMux/Docker pain free. Some input from those with better code knowledge might see issues with the change, maybe I missed an instruction or somesuch. I am also a Sublime Text user, as it happens, I note some instructions are VSCode-centric.

Current master

The contributor gets stuck with a duplicate session error when things are broken by something (some error, closing and re-opening tab). DBeaver showing things are broken. They can fix things with some investigation or they could be time constrained/inexperienced/imposter syndrome/etc. and leave.

https://github.com/owid/owid-grapher/assets/10499070/be1e0055-3036-4047-a2a5-3a7a72542712

With change

The user just needs to run make up twice rather than getting stuck with a duplicate session. DBeaver showing the DB. Things like errors in the UI about TS disappear, and UI refreshes.

https://github.com/owid/owid-grapher/assets/10499070/1e81f99f-9422-4b84-aef3-4ba065412f25