🐝 add no-constant-binary-expression eslint rule

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

🐝 add no-constant-binary-expression eslint rule #3652

Closed sophiamersmann closed 1 month ago

sophiamersmann commented 1 month ago

Adds a no-constant-binary-expression lint rule. I sometimes run Oxlint on our project where this is enabled by default, and I think it makes sense to have it enabled in general.

This PR also fixes a couple of other things that Oxlint complains about, without adding more rules to eslint.

sophiamersmann commented 1 month ago

#3652 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-fix-oxlint

Site-screenshots: https://github.com/owid/site-screenshots/compare/fix-oxlint
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/fix-oxlint

SVG tester:

Number of differences (default views): 0 Number of differences (all views): 0

Edited: 2024-05-27 07:25:35 UTC Execution time: 1.19 seconds

notion-workspace[bot] commented 1 month ago

Fix oxlint issues