Sources modal: Truncated indicator titles show identical labels

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

Sources modal: Truncated indicator titles show identical labels #3654

Open sophiamersmann opened 1 month ago

sophiamersmann commented 1 month ago

Description

Having a max width on the tab labels sometimes leads to an unusable UI:

Expected behaviour

We could:

Make the tab multi-line for long labels
Add a tooltip for each label (would be a bit much I think)

Steps to reproduce

Steps to reproduce the behavior:

Go to https://ourworldindata.org/grapher/decadal-average-death-rates-from-natural-disasters
Open the Sources modal
Show all tabs
Note that they all have the same truncated label

danyx23 commented 2 weeks ago

If the labels are long we should probably either switch to a single column of boxes or line break the text in the boxes so that we can show everything. We'd probably have to experiment with which option is better.

danyx23 commented 2 weeks ago

We will still have to decide if we want to do this always for long labels or only if the beginning is always the same as in the example here.