✨ (line labels) increase height of the line legend / TAS-507

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

✨ (line labels) increase height of the line legend / TAS-507 #3658

Closed sophiamersmann closed 2 weeks ago

sophiamersmann commented 1 month ago

Increases the height of the line legend to both sides. The line legend used to be as tall as the y-axis. Now the line legend uses the full extent of the chart. On smaller screens, a larger height can give us an additional label, see below 👇🏻

Before	After

sophiamersmann commented 1 month ago

#3658 👈
#3647
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

notion-workspace[bot] commented 1 month ago

Increase height of the line legend

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-line-legend-height

Site-screenshots: https://github.com/owid/site-screenshots/compare/line-legend-height
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/line-legend-height

SVG tester:

Number of differences (default views): 1237 ([4e9cd3](https://github.com/owid/owid-grapher-svgs/commit/4e9cd3d5eb5c7fea4858e04302ee7be4dbf8f291)) ❌ Number of differences (all views): 425 ([54ab5d](https://github.com/owid/owid-grapher-svgs/commit/54ab5d44c91ec6aafc7bd9dbc7d7c547a558d9e5)) ❌

Edited: 2024-06-11 09:34:10 UTC Execution time: 1.21 seconds

sophiamersmann commented 2 weeks ago

Merge activity

Jun 11, 5:48 AM EDT: @sophiamersmann started a stack merge that includes this pull request via Graphite.
Jun 11, 5:50 AM EDT: Graphite rebased this pull request as part of a merge.
Jun 11, 5:51 AM EDT: @sophiamersmann merged this pull request with Graphite.