🐛 (slope) only enable dismiss by click after interaction / TAS-508

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

🐛 (slope) only enable dismiss by click after interaction / TAS-508 #3660

Closed sophiamersmann closed 1 month ago

sophiamersmann commented 1 month ago

If a slope chart has a selection by default, then don't dismiss the default selection when the user clicks anywhere in the grapher frame. Only allow dismissing the current selection after the user has interacted with the chart.

Example: https://ourworldindata.org/change-in-female-height-slope

sophiamersmann commented 1 month ago

#3660 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

notion-workspace[bot] commented 1 month ago

SlopeChart: Only enable dismiss by click after interaction

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-slope-dismiss

Site-screenshots: https://github.com/owid/site-screenshots/compare/slope-dismiss
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/slope-dismiss

SVG tester:

Number of differences (default views): 0 Number of differences (all views): 0

Edited: 2024-05-28 16:04:44 UTC Execution time: 1.27 seconds