search

owid / owid-grapher

A platform for creating interactive data visualizations
https://ourworldindata.org
MIT License
1.35k stars 227 forks source link

Hide entity picker drawer when selecting in `Change entity` mode #3669

Open paarriagadap opened 1 month ago

paarriagadap commented 1 month ago

Core problem

When the entity selector is shown as a drawer over the chart and the Change entity button is available, navigation is more awkward compared to the selector fixed to the right, because we need to select, click back in the chart/close and to see how the chart changed. And the process is repeated each time I change the entity.

Proposed solution

It could be useful to hide the selector once we click an entity since the selection has already been made. Only for the Change entity button, though. It makes sense to keep the selector open when we are adding countries.

Context

Slack conversation.

Here's a comparison of the navigation experience for the same chart. When the selector is fixed to the right:

https://github.com/owid/owid-grapher/assets/63430031/bf8676da-1421-463f-832b-623ddc9f628b

When the selector is a drawer over the chart:

https://github.com/owid/owid-grapher/assets/63430031/bb3f8408-9bdd-490e-a9cb-1ea33d5ce345

marcelgerber commented 1 week ago

Sophia is open to this, especially for the slide-in drawer.