🐛 fix ref commas appearing in gdoc articles when paragraph text is between them

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

Closed ikesau closed 1 month ago

ikesau commented 1 month ago

the innerText separating these two footnote spans wasn't interrupting the sibling selector that I added in https://github.com/owid/owid-grapher/pull/3670

This PR puts all span-simple-text spans inside actual span elements to interrupt the CSS sibling selector.

I've checked Chrome, Firefox, and Safari, as well as Grapher and Grapher exports because they also use this renderer in the dod footnotes.

owidbot commented 1 month ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-ref-commas-fix

Site-screenshots: https://github.com/owid/site-screenshots/compare/ref-commas-fix
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/ref-commas-fix

SVG tester:

Number of differences (default views): 0 ✅ Number of differences (all views): 0 ✅

Edited: 2024-05-31 20:54:02 UTC Execution time: 1.20 seconds