owid / owid-grapher

A platform for creating interactive data visualizations
https://ourworldindata.org
MIT License
1.35k stars 227 forks source link

✨ (grapher) fixed tooltip position on mobile / TAS-520 #3679

Closed sophiamersmann closed 8 hours ago

sophiamersmann commented 4 weeks ago

Makes it so that mobile tooltips stick to the bottom (see screenshot below).

Notes:

To do:

Screenshot 2024-06-05 at 14 54 46
sophiamersmann commented 4 weeks ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

owidbot commented 4 weeks ago
Quick links (staging server): Site Admin Wizard

Login: ssh owid@staging-site-mobile-tooltips-fixed

SVG tester: Number of differences (default views): 1342 ([fc5a7d](https://github.com/owid/owid-grapher-svgs/commit/fc5a7dd915fa85e4be1bdc2e0aa6c629943b8361)) ❌ Number of differences (all views): 685 ([00cf2c](https://github.com/owid/owid-grapher-svgs/commit/00cf2c0d5aa5315f0463fb6c4328f3078daf46ad)) ❌

Edited: 2024-06-24 09:45:06 UTC Execution time: 1.19 seconds

notion-workspace[bot] commented 3 weeks ago

Fixed tooltip position on mobile

sophiamersmann commented 8 hours ago

Good to go once map tooltips are fixed. To be continued...