🐛 remove obsolete rebuild table that results in undefined variable

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

🐛 remove obsolete rebuild table that results in undefined variable #3693

Closed danyx23 closed 5 days ago

danyx23 commented 3 weeks ago

While debugging the chart issue that turned out to be an OOM problem I realized that the admin calls rebuildInputOwidTable explicitly at a point when the data for the newly added indicators isn't yet available. It is called again later, I think throuh a reaction.

This PR thus removes what I think is a redudant and semantically misplaced call.

owidbot commented 3 weeks ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-optimize-admin-indicator-refresh

Site-screenshots: https://github.com/owid/site-screenshots/compare/optimize-admin-indicator-refresh
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/optimize-admin-indicator-refresh

SVG tester:

Number of differences (default views): 0 ✅ Number of differences (all views): 0 ✅

Edited: 2024-06-06 15:44:55 UTC Execution time: 1.24 seconds

github-actions[bot] commented 1 week ago

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.