owid / owid-grapher

A platform for creating interactive data visualizations
https://ourworldindata.org
MIT License
1.35k stars 227 forks source link

Grapher style leak in key indicator collection #3701

Open sophiamersmann opened 2 weeks ago

sophiamersmann commented 2 weeks ago

There is a style leak in the Sources modal for Graphers that embedded in a key indicator block:

Screenshot 2024-06-10 at 16 36 49
toni-sharpe commented 1 week ago

@marcelgerber could I have a little more detail on this one, I could fix it I think :-)

danyx23 commented 2 days ago

@toni-sharpe the styling in grapher's sources panel is wrong when embedded on the main website in the featured data block. We have these kinds of css issues with some regularity - you can see some previous PRs that fixed similar issues here: https://github.com/owid/owid-grapher/pulls?q=is%3Apr+is%3Aclosed+style+leak

toni-sharpe commented 21 hours ago

@danyx23 can I get an example of what it should look like? Might be able to look at it over the weekend.