🎉 (stacked bar) add neg/pos color encoding / TAS-547

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

🎉 (stacked bar) add neg/pos color encoding / TAS-547 #3725

Open sophiamersmann opened 1 week ago

sophiamersmann commented 1 week ago

Automatically colours positive and negative values differently (if a single series is plotted)

Implemented as part of an effort to create a set of climate charts, see draft charts on this staging site

Summary

Positive and negative values are coloured differently if a single series is currently plotted and that series actually has positive and negative values
If one faceted chart uses pos/neg colouring, then we switch them all over for consistency
The colours for positive and negative values are currently hard-coded, I don't want to add config for this; let's see how far we get with hard-coded values first

Screenshot

Example on staging: http://staging-site-stacked-bar-colors/admin/charts/7905/edit

sophiamersmann commented 1 week ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#3737
#3735
#3733
#3726
#3725 👈
#3722
#3025
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

notion-workspace[bot] commented 1 week ago

StackedBar: Support pos/neg color encoding

owidbot commented 1 week ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-stacked-bar-colors

Site-screenshots: https://github.com/owid/site-screenshots/compare/stacked-bar-colors
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/stacked-bar-colors

SVG tester:

Number of differences (default views): 0 ✅ Number of differences (all views): 0 ✅

Edited: 2024-06-20 07:09:01 UTC Execution time: 1.22 seconds