owid / owid-grapher

A platform for creating interactive data visualizations
https://ourworldindata.org
MIT License
1.35k stars 227 forks source link

✨ Reordering topics on the homepage #3728

Open spoonerf opened 1 week ago

spoonerf commented 1 week ago

Find and implement an order that makes more sense for the links in our main menu and the "All our topics" section on our homepage - More details in https://github.com/owid/owid-issues/issues/1576

owidbot commented 1 week ago
Quick links (staging server): Site Admin Wizard

Login: ssh owid@staging-site-homepage-reorder

SVG tester: Number of differences (default views): 0 ✅ Number of differences (all views): 0 ✅

Edited: 2024-06-20 13:31:37 UTC Execution time: 1.15 seconds

spoonerf commented 1 week ago

Hi @rakyi!

I started making some preliminary changes to the ordering of topic, the order has changed as expected in the 'All our topics' section at the bottom of the homepage , which is great!

However, it hasn't changed in the 'Browse by topic' section at the top of the homepage, for example I would now expect Global Health to be at the top left under the Health section

Screenshot 2024-06-20 at 15 31 13

I thought both were linked from the same code, but maybe I am missing something?

rakyi commented 1 week ago

I forgot we don't bake everything when we deploy the PR branch to staging and for some reason the list in the footer is taken directly from code, while the top nav is loaded dynamically from a baked file (I don't know why, will ask).

I ran the baking/content deploy manually and now the two lists are in sync in the UI.

spoonerf commented 1 week ago

Ah awesome, thanks for the rapid response!! That's good to know.

rakyi commented 1 week ago

I removed the baking variant, it wasn't necessary to do it that way. You can rebase on master, if you want to get that fix.

spoonerf commented 1 week ago

Amazing, thanks @rakyi!