✨ use dynamic thumbnails in GrapherImage - Githubissues

owid / owid-grapher

A platform for creating interactive data visualizations

https://ourworldindata.org

MIT License

1.35k stars 227 forks source link

✨ use dynamic thumbnails in GrapherImage #3746

Open ikesau opened 3 days ago

ikesau commented 3 days ago

Resolves https://github.com/owid/owid-grapher/issues/3661

Decided to go with an overload to support these 2 cases:

SSR where we can only ever know the slug
gdocs SSR where we have a full URL (potentially with a query string)

Seemed better than converting all the slugs to full URLs but I'm happy to change it if we don't like the overload pattern.

GrapherImage usage:

gdocs/blocks/Charts.tsx - works
GrapherPage.tsx - works
GrapherWithFallback.tsx - works
RelatedChart.tsx - works
AllChartsListItem.tsx - works
DynamicCollection.tsx - n/a, needs JS to function
StaticCollection.tsx - n/a, needs JS to function

owidbot commented 3 days ago

Quick links (staging server): Site	Admin	Wizard

Login: ssh owid@staging-site-gdoc-grapher-previews

Site-screenshots: https://github.com/owid/site-screenshots/compare/gdoc-grapher-previews
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/gdoc-grapher-previews

SVG tester:

Number of differences (default views): 0 ✅ Number of differences (all views): 0 ✅

Edited: 2024-06-25 22:51:39 UTC Execution time: 1.12 seconds