owingsbj / ModSynth

A modular synthesizer for Android
Apache License 2.0
16 stars 4 forks source link

MIDI controller selection via MIDI not working in V6 #33

Open riban-bw opened 5 years ago

riban-bw commented 5 years ago

Press and hold a control parameter to open the MIDI controller selector. Move a slider on a connected MIDI controller. Expected behaviour: ModSynth MIDI control value changes to that of the external MIDI controller control number. Actual behaviour: ModSynth MIDI control value remains unchanged. Looking at the source code I cannot see where MidiControlDialog::MidiControlDialog is called. It looks like it is commented out in MySynth::onMidiControlChange so may be a victim of the migration to MySynth abstraction.

owingsbj commented 5 years ago

I believe this is fixed now.