owkin / PyDESeq2

A Python implementation of the DESeq2 pipeline for bulk RNA-seq DEA.
https://pydeseq2.readthedocs.io/en/latest/
MIT License
573 stars 60 forks source link

Fix Inference n_cpus overwritten issue #293

Closed yihming closed 3 months ago

yihming commented 3 months ago

Reference Issue or PRs

This PR is to fix Issue #288 .

What does your PR implement? Be specific.

The current initialization of DeseqDataSet always overwrites its Inference object's n_cpus. So no matter which value is specified for n_cpus when declaring an Inference object, when passed to DeseqDataSet, its n_cpus is always overwritten to use all available vCPUs.

My implementation just restricts that Inference's n_cpus can only be overwritten if DeseqDataSet's n_cpus is not None.

umarteauowkin commented 3 months ago

Thanks a lot @yihming :)