unpack_arr would fail in nested forward/reverse mode

owlbarn / owl

Owl - OCaml Scientific Computing @ https://ocaml.xyz

MIT License

1.2k stars 120 forks source link

Closed ghennequin closed 2 years ago

ghennequin commented 2 years ago

This is fixed by first extracting the primal' value.

tachukao commented 2 years ago

If we use primal', I don't think we need unpack_arr?

ghennequin commented 2 years ago

We do need unpack_arr (primal' still returns a Algodiff.D.t value).