search

owlbarn / owl

Owl - OCaml Scientific Computing @ https://ocaml.xyz
MIT License
1.22k stars 124 forks source link

ssqr_diff' modifies inputs in place #645

Closed patrick-nicodemus closed 8 months ago

patrick-nicodemus commented 1 year ago

The function Mat.ssqr_diff' appears to modify its inputs in place without warning. If you try to compute Mat.ssqr_diff' A B then this has the side effect A.(i,j) <- (A.(i,j) -. B.(i,j))**2..

jzstark commented 8 months ago

Thanks for fixing this issue! It's a high quality contribution!

patrick-nicodemus commented 8 months ago

I would be interested in continuing to assist with the maintenance of Owl if you or others can suggest work to help. I am not an experienced OCaml developer especially concerning the OCaml / C interface. However I am willing to learn what is necessary if you have specific issues you can suggest to address.

On Thu, Mar 7, 2024, 2:40 PM J. Roger Zhao @.***> wrote:

Thanks for fixing this issue! It's a high quality contribution!

— Reply to this email directly, view it on GitHub https://github.com/owlbarn/owl/issues/645#issuecomment-1984295979, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2OS47T5FFOKDC7IKJBSI3YXC7DHAVCNFSM6AAAAAA4L3OXYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGI4TKOJXHE . You are receiving this because you authored the thread.Message ID: @.***>