search

owlboy / greatpug-public

A Bar in the Metaverse (VRChat)
http://thegreatpug.com
53 stars 6 forks source link

Hold to grab constantly pops up #20

Closed auronx223 closed 4 years ago

auronx223 commented 5 years ago

Describe the bug A clear and concise description of what the bug is.

On Rare occasions, some instances constantly bring up the option to "Hold to Grab". This bug affects the instance and only seems to affect VR users for some reason. This prevents picking up any item, or sitting in seats, etc. and regardless of where you go in the map it constantly pops up every 5 seconds or so (also causes the controllers to buzz each time).

Desktop users can still pick up items and sit on seats whilst every other VR user in the instance has the issue. When changing instance to another pug seems to resolve the issue, although returning to the instance will still have the bug occur.

Some occasions I have heard the phone noises constantly follow me when this occurs, especially when pressing the grip button and holding my hand next to my head.

To Reproduce Steps to reproduce the behavior:

Unsure of what exactly causes this issue. Seems to be an issue with the instance and happens randomly.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

VRChat_1920x1080_2019-05-08_20-19-16 995

Are you in VR or Desktop mode?

VR with Oculus Rift.

Additional context Add any other context about the problem here. I've only seen this bug occur in the Pug, so its possibly a bug with the map instead of VRChat.

owlboy commented 5 years ago

Hello! I really appreciate the Bug Report. If this instance is still live, a VRChat output log would be very helpful.

This is an issue that has been on-going for over a year now. I'm not sure exactly what state it is getting into, nor sure how to reproduce it. It seems as though a pickup or pickups has gotten into what can only be described as a superposition. And the client does not notice this and reset it.

But I can only hypothesize that it seems to be an issue that is likely caused by one of the following factors: • Triggers were broken by a modified client manipulating them or the hierarchy into a bad state. • The instance itself is very old and has not survived all the master handoffs it has had to do • There is an issue with older instances and buffered triggers getting out of control after a long period of time. • Something specifically about the teleportTo VRChat Trigger is not stable and it very rarely gets tripped up.

I believe we both have not observed this in other worlds because their public instances do not last as long, and have pickups in them.

All of this could be wrong, and I am willing to investigate alternate theories as to the cause. Especially if someone can reproduce it. As it stands now, I am 75% confident this is an issue with the client or how triggers are allowed to behave, and not the world.

auronx223 commented 5 years ago

Looking in the VRChat log around when I took the picture shows a bunch of errors same as below:

2019.05.08 20:19:59 Error - Infinity or NaN floating point numbers appear when calculating the transform matrix for a Collider. Scene hierarchy path " - Props/Props (Pickups) - Main Bar/tumblr-voo-doo (2)/ObjectRespawner"

owlboy commented 5 years ago

Thanks for the info! That looks like what I have seen in the past when this issue arises.

That Glass is literally attempting to teleport itself to a non-existent coordinate in space.

All4thlulz commented 5 years ago

I came here to also report this issue and while it may not be of any further help here is a list on pastebin of all the different objects that were throwing errors throughout a few broken instances of the great pug.

Great Pug Hold To Grab Errors It is not a complete list because we are talking I have an output log with thousands of these errors over different instances.

Edit: Would you still like the output log?

Edit2: I have experienced the hold to grab bug in other maps but I have not experienced in other maps in recent updates. The pug has been the first consistent few instances in a while that I have seen this issue.

owlboy commented 5 years ago

@All4thlulz That bit of the log you have shared is good enough. Thanks!

owlboy commented 5 years ago

I am pretty sure this is a bug on the VRChat/Unity side of things. The only way for me to fix it would be to remove all pickups from the world. - And that is not an option I am willing to consider right now.

The reason you may see it in The Pug more often than others is just due to the age of instances The Great Pug currently averages. Lots of people filter in an out leading to the instances to last a long time. Leading to more time for the bug to randomly happen.

I did some googling on the error, and it leads me to this Unity issue: https://issuetracker.unity3d.com/issues/transform-dot-position-values-becomes-to-nan-when-one-gameobject-rotates-while-colliding-the-edge-of-another-gameobject

Sadly this means engine bug. And I can already hear VRChat saying "not our problem, we have too much else to fix. Things work fine in the vast majority of cases with Pickup Objects."

I would hope they could put in something that catches when this is happening and reset the location of the object.

Should this be a malicious user setting the location to NAN, then that is also something VRChat has to take care of. Either with stronger security preventing modified clients, or again with a check that kicks the Pickup Object out of the bad state.

Other potential solutions to this issue, and things similar that VRChat could implement:

owlboy commented 5 years ago

Here is the Canny item that applies to this bug. Please throw some upvotes at it: https://vrchat.canny.io/bug-reports/p/rigidbodies-imploding-hold-to-grab-bug

owlboy commented 5 years ago

Does anyone still see this issue happening in The Great Pug or other worlds? I have not run across it for a good while now (knock on wood). It may have been fixed as a side effect of other work done on ObjectSync, etc.

auronx223 commented 5 years ago

I haven't seen it in awhile personally, hopefully it is resolved.

owlboy commented 4 years ago

I think it's safe to say this has been resolved. It's weird how some bugs just vanish, and no one is quite sure why.