search

owlcollab / oboformat

Automatically exported from code.google.com/p/oboformat
5 stars 2 forks source link

retain the order of frames #90

Closed musketyr closed 8 years ago

musketyr commented 8 years ago

In many situations it's better to keep the order of the frames loaded. Using LinkedHashMap instead of just plain HashMap guarantees this.

cmungall commented 8 years ago

Thanks for the PR, but I would recommend against this, the guide recommends a particular deterministic ordering, and this is necessary to support diffs, and not clear how the ordering would be preserved through obo/owl mapping.

See also https://github.com/owlcs/owlapi/issues/273

Also note the code for this now lives in owlcs - @hdietze we should retire the code here to make this clear

hdietze commented 8 years ago

The frame order during writing of OBO files is done via an explicit sort step with a given set of sorting priorities. Even if we preserve the original order in the in-memory model it will be lost in this step.

see: owlapi/oboformat/src/main/java/org/obolibrary/oboformat/writer/OBOFormatWriter.java

As recommend by @cmungall I will reject the pull request and have already deleted the code.

musketyr commented 8 years ago

As I only use your OBO library for reading this is not valid reason to me at all but I can live with my own fork. Thank you for cooperation and explanation.

Dne út 1. 3. 2016 0:08 uživatel hdietze notifications@github.com napsal:

Closed #90 https://github.com/owlcollab/oboformat/pull/90.

— Reply to this email directly or view it on GitHub https://github.com/owlcollab/oboformat/pull/90#event-572051332.