search

owlcollab / owltools

OWLTools
BSD 3-Clause "New" or "Revised" License
108 stars 33 forks source link

Extend solr loader to populate new closure fields #243

Open cmungall opened 6 years ago

cmungall commented 6 years ago

Not to be started on until: https://github.com/geneontology/amigo/issues/478

Part of: https://github.com/orgs/geneontology/projects/13

yy20716 commented 6 years ago

Chris, I am sorry but I am not sure whether I understood this task correctly. Do you think that I just need to add codes similar to the previous task that adds regulate-only closure like this, i.e. modifying graph/RelationSets.java and solrj/GafSolrDocumentLoader.java? The part I am not sure about is how to express "all genes in either of the above" in your amigo ticket. In other words, do you think I just need to add the slash like this REGULATES = "regulates/is_a/part_of"; to represent the logical OR (or either)? I would appreciate it if you could clarify my question. Thank you.

cmungall commented 6 years ago

don't worry, I'm just registering the ticket as part of a larger project, I will expand the ticket and explain more later, you can ignore for now

On 9 Mar 2018, at 12:30, HyeongSik Kim wrote:

Chris, I am sorry but I am not sure whether I understood this task correctly. Do you think that I just need to add codes similar to the previous task that adds regulate-only closure like this, i.e. modifying graph/RelationSets.java and solrj/GafSolrDocumentLoader.java? The part I am not sure about is how to express "all genes in either of the above" in your amigo ticket. In other words, do you think I just need to add the slash like this REGULATES = "regulates/is_a/part_of"; to represent the logical OR (or either)? I would appreciate it if you could clarify my question. Thank you.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/owlcollab/owltools/issues/243#issuecomment-371936785