search

owlcollab / owltools

OWLTools
BSD 3-Clause "New" or "Revised" License
107 stars 33 forks source link

Upgrade to OWL API 4.5.29. #327

Closed balhoff closed 2 months ago

balhoff commented 2 months ago

I updated a bunch of tests, but had to ignore a few due to some unfamiliarity and suspected disused code. This OWL API upgrade is important for maintaining OBO format parity with Protege and ROBOT.

balhoff commented 2 months ago

I don't think we have CI checks enabled here, but the remaining tests do all pass for me locally.

balhoff commented 2 months ago

@kltm if I merge this PR, would it immediately start getting built and used in the GO pipeline, or is the pipeline getting owltools from ODK now?

kltm commented 2 months ago

@balhoff Mixed bag, perhaps. Ontology production uses the ODK ('obolibrary/odkfull:v1.4') in various branches. However, owltools also gets used for building the solr index and doing "predictions" in the pipeline; these seem to follow a local build aimed at master.

balhoff commented 2 months ago

@kltm I was thinking about the timing of things. I would merge this into master and then make an update to ODK. Once that is out the ontology build will start using it. But are you okay with the pipeline immediately using the new OWL API? I think it will be okay for the ontology, since it won't be saving out ontology files.

kltm commented 2 months ago

I'm not sure of the scope of any disruption, if any, as we're locked to ODK in the ontology build itself. Or, to ask another way, why would the solr loads or predictions creation change if this went in?

balhoff commented 2 months ago

I'm not sure of the scope of any disruption, if any, as we're locked to ODK in the ontology build itself. Or, to ask another way, why would the solr loads or predictions creation change if this went in?

I don't think they would! Just wanted to check for any apprehension you may have. But it ought to be unchanged.

kltm commented 2 months ago

@balhoff Nah--my only ask would be that this is done either late today or early tomorrow, to give the current snapshot a chance to finish with a guaranteed version throughout the run.