owlcs / owlapi

OWL API main repository
821 stars 315 forks source link

OWLOntologyID: change visibility of private fields to protected #1054

Closed sszuev closed 2 years ago

sszuev commented 2 years ago

ONTAPI extends this class in order to encapsulate jena Node (see https://github.com/owlcs/ont-api/blob/3.x.x/src/main/java/com/github/owlcs/ontapi/ID.java). Right now to achieve this purpose we use reflection. Although that version of OWLOntologyID is just a view, using reflection is not good in general. I think it is better to turn this class into an interface, but I'm not sure about side effects (see #1034 - it is about interfaces). These suggested changes seem to be safe enough.