search

owlcs / owlapi

OWL API main repository
821 stars 315 forks source link

OBO serialisation illegal axiom annotation #1093

Closed hkir-dev closed 1 year ago

hkir-dev commented 1 year ago

Fix for the issue: https://github.com/ontodev/robot/issues/1089

OBO serializer is adding a weird axiom annotation when an illegal annotation property is declared:

<owl:AnnotationProperty rdf:about="http://www.w3.org/1999/02/22-rdf-syntax-ns#type"/>

This fix is one of the two alternative solutions. Other alternative is: https://github.com/owlcs/owlapi/pull/1092

During OWL to OBO conversion, illegal annotation property and its value are filtered.

matentzn commented 1 year ago

@ignazio1977 this is ready I think. It looks good to my eyes, but maybe sanity check the code.

Will PRs like this made on one version (like 4) be automatically perpetuated to 5 and 6?

Once this is merged, could you do another release of the OWL API? 🙏

ignazio1977 commented 1 year ago

Will PRs like this made on one version (like 4) be automatically perpetuated to 5 and 6?

Not automatically but I'll make sure the same changes are applied to version 5 and 6

ignazio1977 commented 1 year ago

4.5.25 released

matentzn commented 1 year ago

AMAZING Thank you!