search

owlprotocol / contracts

MIT License
3 stars 4 forks source link

Lootbox test consistency #373

Closed corbanvilla closed 2 years ago

corbanvilla commented 2 years ago

Some of the lootbox tests fail with epoch tests. I think this is just due to slow runners. Implement some concurrent requests to prevent this.

corbanvilla commented 2 years ago

/cib

github-actions[bot] commented 2 years ago

Branch issue-373 created! Clone with: git fetch && git checkout --track origin/issue-373 Rebase develop branch changes with: git checkout issue-373 && git rebase develop

HrikB commented 2 years ago

If you are unable to alleviate the inconsistency... perhaps better just keep that as a solidity test and remove the JS/TS test altogether

corbanvilla commented 2 years ago

@HrikB I'm good with that if it's ready 👍