Account Page Section & Components

owlprotocol / metascan

Multi-chain EVM blockchain explorer using web3-redux to fetch data

MIT License

1 stars 1 forks source link

Account Page Section & Components #18

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

Suggested workflow: First build small to large components as modules, then integrate in page/screen.
You are welcome to divide the work into small PR's if needed.
Check our existing components such as the AddressBar and the Card Wrapper - you are likely to re-use them in here.
For any questions, don't hesitate to ask ;-)
if its UX/UI related question then on the Slack channel #metascan

Figma Link of the Design closes #17

netlify[bot] commented 2 years ago

✔️ Deploy Preview for metascan ready!

🔨 Explore the source changes: 143fc12ae7c9b5a68d235313f07446498ce66f25

🔍 Inspect the deploy log: https://app.netlify.com/sites/metascan/deploys/61d3288c48c7e90007ee6b73

😎 Browse the preview: https://deploy-preview-18--metascan.netlify.app/

netanelben commented 2 years ago

@HrikB I can see that this PR has changes which are not belong to the subject - such as files i created from another branch. I can see you did use the /cib command which should branch out from develop which is what we want - but im not sure how did these changes got into this PR - if you can remove them so i could focus on your changes.

Another thing i saw is you modified the Linter - we do not want to silent the linter to that level or at all. take time and find the syntax mistakes that is shouting at - and try solve them. i know its little hard, me myself found in situations where i hate it = but, we want to keep high standards here :-)

if you find lint issue, post on slack - we can help ! happy holidays ^_^

HrikB commented 2 years ago

@HrikB I can see that this PR has changes which are not belong to the subject - such as files i created from another branch. I can see you did use the /cib command which should branch out from develop which is what we want - but im not sure how did these changes got into this PR - if you can remove them so i could focus on your changes.

Another thing i saw is you modified the Linter - we do not want to silent the linter to that level or at all. take time and find the syntax mistakes that is shouting at - and try solve them. i know its little hard, me myself found in situations where i hate it = but, we want to keep high standards here :-)

if you find lint issue, post on slack - we can help ! happy holidays ^_^

HrikB commented 2 years ago

@netanelben Could you let me know which changes I need to reverse that we on files I wasn't supposed to touch?

And regarding the linter, I think I only silenced something that wasn't letting me have unused variables but I needed a variable in a function to be unused. But I can try to figure out a work around.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for metascan-storybook ready!

🔨 Explore the source changes: 143fc12ae7c9b5a68d235313f07446498ce66f25

🔍 Inspect the deploy log: https://app.netlify.com/sites/metascan-storybook/deploys/61d3288d12fb530008134af6

😎 Browse the preview: https://deploy-preview-18--metascan-storybook.netlify.app