owlsomely / angular-image-zoom

Native AngularJs Directive that provide image hover zoom feature
http://owlsomely.github.io/angular-image-zoom/
MIT License
40 stars 23 forks source link

Bower Requires release tag, move template inside directive file #2

Closed willbuck closed 9 years ago

willbuck commented 10 years ago

Hello There!

It would be great if you could add a git tag for this project following semver conventions (v$MAJOR_RELEASE_NUMBER.$MINOR_REALSE_NUMBER.$PATCH_NUMBER).

Something as simple as

git tag -a v0.1.0 -m "Initial release" git push origin v0.1.0

Would suffice. However, one thing you'd likely want to change is the templateUrl reference in your directive, as most folks won't probably want to serve the template from their server root.

I would probably just include the template in the directive since its reasonably small, and not have it in its own file

  template: ['<div class="image-zoom">',
      '<div class="image-zoom-lens" data-ng-style="getLensStyle()"></div>',
      '<img class="image" ng-src="{{ imageSrc }}"/>',
    '</div>'].join('');

I'd be happy to submit a pull request if you like for the directive change, but the tagging you'd have to do yourself as the repo owner

Thanks very much! Hope finishing the bower publishing will help the success of your library :)

uschen commented 10 years ago

@willbuck pull request is welcome! I prefer to leave the template in src dir and use grunt-angular-templatecache as an option to compile the template into dist file.

Will follow semver conventions and push to bower after some necessary improvements are done.

uschen commented 9 years ago

https://github.com/owlsomely/angular-image-zoom/releases