search

owlsomely / angular-image-zoom

Native AngularJs Directive that provide image hover zoom feature
http://owlsomely.github.io/angular-image-zoom/
MIT License
40 stars 23 forks source link

Incorrect positioning of lens. #7

Closed DropsOfSerenity closed 9 years ago

DropsOfSerenity commented 9 years ago

In deeply nested html structure the lens was not being positioned correctly. In order to fix this getOffset just needed to traverse up the offsetParent tree and add the offsets until it reaches the top.

While I was at it, I fixed your demo site as well :) Since grunt had demo/ and dist/ as roots, dist/image-zoom.js was not resolving.

DropsOfSerenity commented 9 years ago

Actually, your demo site works you just need to deploy with grunt deploy so that dist is actually collected into demo/dist/

DropsOfSerenity commented 9 years ago

see: http://dropsofserenity.github.io/angular-image-zoom/ for my changes deployed

uschen commented 9 years ago

@DropsOfSerenity nice work. will merge