Trinkets usable even after being banned

Unixkitty commented 3 years ago

Minecraft 1.16.5 Forge 36.2.2 Lost Trinkets 0.1.27

Description: Blacklisting trinkets doesn't seem to remove them from players, as stated it should in the config file. For context, on the first two screenshots only the server's config was modified, the client's had default settings. The server's debug.log appropriately lists the banned trinkets however:

[11Aug2021 14:25:09.095] [Thread-0/INFO] [losttrinkets/Config]: Gathering Trinkets...
[11Aug2021 14:25:09.095] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:book_o_enchanting
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Non-Random: losttrinkets:dark_egg
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:pillow_of_secrets
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:octopick
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:ruby_heart
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:magical_herbs
[11Aug2021 14:25:09.096] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:magical_feathers
[11Aug2021 14:25:09.097] [Thread-0/INFO] [losttrinkets/Config]: Banned: losttrinkets:broken_totem

For example with the Magical Feathers trinket, I can still fly and use it as shown on the screenshot: 2021-08-11_15 45 26

And on this screenshot other blacklisted trinkets can be seen and used in my unlocked trinket list: 2021-08-11_15-56

It would seem applying the config to the client is also limited only to making the client append text to trinket items such as "Disabled", (I still have all the disabled trinkets and can still use them): 2021-08-11_16 41 45

Log snippet from client:

[11Aug2021 16:31:21.160] [modloading-worker-13/INFO] [losttrinkets/Config]: Enabled: 61 Disabled: 7
[11Aug2021 16:31:21.160] [modloading-worker-13/INFO] [losttrinkets/Config]: Random: 60 Non-Random: 1
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:magical_feathers
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:book_o_enchanting
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:pillow_of_secrets
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:octopick
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:ruby_heart
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:magical_herbs
[11Aug2021 16:31:21.160] [modloading-worker-13/WARN] [losttrinkets/Config]: Redundant Non-Random Trinket (already banned): losttrinkets:broken_totem

Expected behavior: Blacklisting trinkets works as advertised.

BlueAgent commented 3 years ago

Banned trinkets should be removed when players log in. Is this not working?

Also if a trinket is banned you don't have to also put it in the non-random list.

Unixkitty commented 3 years ago

Nope... nothing gets removed from player data, the config only seems to prevent the banned trinkets from being awarded?

The second part was more for testing (still not working? What if I added it there too?)

BlueAgent commented 3 years ago

I can't seem to reproduce... Works fine for me on a dedicated server. It also removes the item from players still in the game or if they log back in and prevents unlocking without even restarting the server too.

https://user-images.githubusercontent.com/630920/130322425-16628160-2abc-41c1-9178-ff30b0117d25.mp4

Unixkitty commented 3 years ago

Interesting, that's exactly how I assumed it would work based on the config comments and whatnot...

Could it be a mod conflict? There doesn't seem to be anything relevant in the log surrounding losttrinket's messages.

Unfortunately I am unable to pinpoint a possible conflict at this time. Here is the modlist:

abnormals_core-1.16.5-3.2.0.jar
abnormals_delight-1.16.5-1.1.1.jar
absentbydesign-1.16.5-1.5.0.jar
Abundance-1.16.5-1.0.5.jar
advancedperipherals-0.7r.jar
AI-Improvements-1.16.2-0.3.0.jar
aiotbotania-1.16.5-1.8.1.jar
AkashicTome-1.4-16.jar
alchemistry-1.16.5-1.jar
alexsmobs-1.11.1.jar
alib-1.16.4-1.jar
allurement-1.16.5-1.2.0.jar
Apotheosis-1.16.4-4.6.1.jar
appleskin-forge-mc1.16.x-2.1.0.jar
Aquaculture-1.16.5-2.1.20.jar
Architects-Palette-1.16.4-1.1.4.jar
architectury-1.20.29-forge.jar
areas_1.16.5-2.8.jar
Artifacts-1.16.5-2.10.0.jar
astralsorcery-1.16-1.16.5-1.13.12.jar
atmospheric-1.16.5-3.1.0.jar
Atum-1.16.5-2.2.6.jar
AutoRegLib-1.6-49.jar
autumnity-1.16.5-2.1.1.jar
backpacked-1.10.1-1.16.3.jar
balancedenchanting-1.0.jar
bamboo_blocks-1.16.5-3.0.0.jar
Bayou-Blues-1.16.5-1.0.5.jar
BedBenefits-1.16.5-5.0.3.jar
bedspreads-forge-1.16.5-5.1.0.2.jar
berry_good-1.16.5-4.1.1.jar
BetterAdvancements-1.16.5-0.1.0.105.jar
Better-Badlands-1.16.5-2.0.3.jar
betterbiomeblend-1.16.4-1.2.9-forge.jar
BetterBurning-1.16.5-6.0.5.jar
BetterCaves-Forge-1.16.4-1.1.2.jar
BetterDiving-1.16.5-1.3.2.jar
betterendforge-1.16.4-1.6.0.jar
BetterMineshafts-Forge-1.16.4-2.0.4.jar
BetterStrongholds-1.16.4-1.2.1.jar
BetterTitleScreen-1.16.4-1.10.2.jar
biomeidfixer-1.16.5-1.0.1.s4.jar
BiomesOPlenty-1.16.5-13.1.0.467-universal.jar
BloodMagic-1.16.4-3.1.0-15.jar
blue_skies-1.16.5-1.1.3.jar
Bookshelf-Forge-1.16.5-10.2.27.jar
BorderlessWindow-1.16.5-1.2.0.jar
Botania-1.16.5-419.jar
buildinggadgets-1.16.5-3.8.0.jar
buzzier_bees-1.16.5-3.0.1.jar
caelus-forge-1.16.5-2.1.3.1.jar
carryon-1.16.5-1.15.5.15.jar
catjammies-1.1.0.jar
cc-tweaked-1.16.5-1.98.1.jar
cfm-7.0.0pre22-1.16.3.jar
chemlib-1.16.4-1.jar
cherishedworlds-forge-1.16.5-5.1.1.0.jar
chipped-1.1.2.jar
chiselsandbits-0.3.4-RELEASE.jar
chocolate-1.3.0-1.16.4.jar
chunkloaders-1.1.7-mc1.16.5.jar
citadel-1.7.3-1.16.5.jar
clickadv-1.5.jar
ClientTweaks_1.16.3-5.3.0.jar
cloth-config-4.11.26-forge.jar
Clumps-6.0.0.25.jar
cofh_core-1.16.5-1.3.1.jar
collective-1.16.5-2.58.jar
ColtCosmeticArmorMod-1.2.5.jar
comforts-forge-1.16.5-4.0.1.2.jar
connectivity-2.2-1.16.5.jar
convenient_gadgetry-1.16.5-0.1.5.1.jar
CookingForBlockheads_1.16.5-9.3.3.jar
CosmeticArmorReworked-1.16.5-v4.jar
createaddition-1.16.5-20210819a.jar
create-mc1.16.5_v0.3.2d.jar
CTM-MC1.16.1-1.1.2.6.jar
curioofundying-forge-1.16.5-5.2.0.0.jar
curios-forge-1.16.5-4.0.5.2.jar
CuriosQuarkOBP-1.16.5-1.0.2.jar
Curious Armor Stands-1.16.5-2.1.2.jar
curiouselytra-forge-1.16.5-4.0.2.3.jar
curiousshulkerboxes-forge-1.16.5-4.0.1.0.jar
customizableelytra-1.16.4-1.5.4.jar
DarkUtilities-1.16.5-8.0.9.jar
dash-1.16.4-1.0.1.jar
decorative_blocks-1.16.4-1.7.2.jar
decorative_blocks_abnormals-1.2.jar
DefaultOptions_1.16.5-12.2.1.jar
demagnetize-forge-1.16.2-1.2.2.jar
Ding-1.16.5-1.3.0.jar
drawerfps-2.0.jar
Druidcraft-1.16.5-0.4.52.jar
dungeons_gear-1.16.5-3.0.17.jar
dungeons_mobs-1.16.5-1.0.10.jar
dungeons_plus-1.16.5-1.1.5.jar
eidolon-0.2.7.jar
elevatorid-1.16.5-1.7.13.jar
embellishcraft-1.16.5-3.4.0.0.jar
enchantedbookredesign-3.3-1.16.4.jar
endergetic-1.16.4-3.0.0.jar
engineersdecor-1.16.4-1.1.14.jar
Enhanced-Mushrooms-1.16.5-3.0.9.jar
ensorcellation-1.16.5-1.3.1.jar
EntityCulling-1.16.5-2.1.6.jar
environmental-1.16.5-1.1.0.jar
expandability-2.0.1-forge.jar
extlights-3.3.jar
extraboats-1.16.5-2.1.0.jar
fairylights-4.0.5-1.16.5.jar
FallingTree-1.16.5-2.11.5.jar
FarmersDelight-1.16.5-0.4.6.jar
farsight-1.6.jar
FastFurnace-1.16.4-4.4.0.jar
FastLeafDecay-v25.jar
FastWorkbench-1.16.4-4.5.1.jar
ferritecore-2.0.5-forge.jar
finallyfarmabledyes-1.16.4-1.2.0.1.jar
findme-1.16.3-2.2.0.0.jar
fishingreal-1.16.3-1.0.0.jar
flickerfix-1.0.1.jar
FluxNetworks-1.16.5-6.1.7.12.jar
flywheel-1.16-0.2.3.jar
forbidden_arcanus-16.2.0-beta-4.jar
FramedBlocks-2.9.3.jar
Fruitful-1.16.5-2.1.0.jar
ftb-backups-2.1.1.6.jar
ftb-chunks-forge-1605.3.1-build.41.jar
ftb-library-forge-1605.3.2-build.64.jar
ftb-teams-forge-1605.2.1-build.20.jar
ftb-ultimine-forge-1605.3.0-build.25.jar
GameStages-Forge-1.16.5-7.3.9.jar
gemspark-1.16.4-1.2.3.0.jar
gemspork-1.16.4-1.5.0.jar
goblintraders-1.6.0-1.16.3.jar
GravelMiner_1.16.3-10.2.0.jar
Guide-API-VP-1.16.5-2.2.2.jar
HealthOverlay-1.16.5-3.0.0.jar
horsestandstill-1.16.5-1.0.2.jar
iChunUtil-1.16.5-10.4.1.jar
ImmersiveEngineering-1.16.5-5.0.3-138.jar
ImmersivePetroleum-1.16.5-3.3.0-5.jar
immersiveposts-1.16.5-4.1.1.jar
incontrol-1.16-5.2.0.jar
industrial-foregoing-1.16.5-3.2.14.5-13.jar
InventoryEssentials_1.16.5-2.3.2.jar
InventoryHud_[1.16.2-1.16.5].forge-3.4.0.jar
inventorysorter-1.16.1-18.1.0.jar
ironchest-1.16.5-11.2.13.jar
Jade-1.16.4-2.7.2.jar
JAOPCA-1.16.5-3.4.0.12.jar
jei-1.16.5-7.7.1.118.jar
jeiintegration_1.16.5-7.0.1.15.jar
JustEnoughProfessions-1.16.5-1.2.1.jar
JustEnoughResources-1.16.5-0.12.1.121.jar
Kiwi-1.16.5-3.5.2.jar
KleeSlabs_1.16.5-9.2.1.jar
kubejs-blood-magic-1604.1.0.4.jar
kubejs-create-1605.1.2-build.7.jar
kubejs-forge-1605.3.15-build.90.jar
kubejs-immersive-engineering-1604.1.0.12.jar
kubejs-mekanism-1604.1.1.6.jar
kubejs-ui-forge-1605.1.4-build.12.jar
lazydfu-0.1.3.jar
leap-1.16.4-1.1.1.jar
LibX-1.16.3-1.0.76.jar
light-overlay-5.8.1.jar
Lollipop-1.16.5-3.2.9.jar
LostTrinkets-1.16.5-0.1.27.jar
mapperbase-1.16.5-2.4.0.0.jar
MaxHealthFix-Forge-1.16.5-1.0.4.jar
mcw-bridges-1.0.6-mc1.16.5.jar
mcw-doors-1.0.3-mc1.16.5.jar
mcw-fences-1.0.0-mc1.16.5.jar
mcw-furniture-2.0.1-mc1.16.5.jar
mcw-roofs-2.0.1-mc1.16.5-4.jar
mcw-trapdoors-1.0.2-mc1.16.5.jar
mcw-windows-1.0.3-mc1.16.5.jar
Mekanism-1.16.5-10.0.21.448.jar
MekanismAdditions-1.16.5-10.0.21.448.jar
MekanismGenerators-1.16.5-10.0.21.448.jar
MekanismTools-1.16.5-10.0.21.448.jar
mgui-1.16.5-3.2.0.jar
mightyarchitect-mc1.16.3_v0.5.jar
minecolonies-0.14.341-ALPHA-universal.jar
mininggadgets-1.7.5.jar
mining_helmet-1.16.5-2.0.1.jar
MmmMmmMmmMmm-1.16.5-1.2.0.jar
ModernUI-1.16.5-2.5.1.86-universal.jar
morecfm-1.3.1-1.16.3.jar
morered-1.16.5-2.1.1.0.jar
Morpheus-1.16.5-4.2.70.jar
MouseTweaks-2.14-mc1.16.2.jar
mowziesmobs-1.5.19.jar
mysticalworld-1.16.5-0.3.2.17.jar
MythicBotany-1.16.5-1.4.1.jar
NaturesCompass-1.16.5-1.9.1-forge.jar
neapolitan-1.16.5-2.1.0.jar
Neat 1.7-27.jar
neoncraft-2.0.jar
netheritehorsearmor-1.7.jar
NetherPortalFix_1.16.3-7.2.1.jar
nethers_delight-1.1.jar
Notes-1.16.5-1.2.3.jar
observerlib-1.16.5-1.5.3.jar
occultism-1.16.5-1.8.2.jar
OpenLoader-1.16.5-9.0.3.jar
overloadedarmorbar-5.1.0.jar
PackMenu-1.16.4-2.4.2.jar.disabled
paintings-1.16.4-7.0.0.1.jar
PassableFoliage-1.16.5-2.3.1.jar
Patchouli-1.16.4-53.1.jar
peculiars-1.16.5-2.0.0.jar
performant-1.16.2-5-3.72m.jar
personality-1.16.5-1.0.2.jar
Ping-1.16.4-1.6.9.jar
pitg-1.16.5-2.0.1.jar
Placebo-1.16.4-4.5.0.jar
polymorph-forge-1.16.5-0.25.jar
portable_stonecutter-1.16.4-1.3.4.jar
portality-1.16.4-3.2.2.jar
Powah-1.16.5-2.3.16.jar
Psi 1.16-95.jar
QuarkOddities-1.16.3.jar
Quark-r2.4-316.jar
randompatches-2.4.4-forge.jar
ReAuth-1.16-Forge-3.9.3.jar
redstonepen-1.16.5-1.0.6.jar
refinedstorage-1.9.15.jar
refinedstorageaddons-0.7.3.jar
rhino-1605.1.2-build.48.jar
rsgauges-1.16.4-1.2.11.jar
rsrequestify-1.16.5-2.1.3.jar
Runelic-1.16.5-7.0.1.jar
savageandravage-1.16.5-3.1.0.jar
scuba-gear-1.16.5-1.0.3.jar
selene-1.16.5-1.6.jar
serverconfigupdater-1.3.jar
ServerTabInfo-1.16.4-1.3.3.jar
simple-rpc-1.16.5-2.3.1.jar
simplylight-1.16.4-1.1.3.jar
SnowRealMagic-1.16.4-2.5.8.jar
snowundertrees-1.16.5-v1.1.4.jar
sounddeviceoptions-1.4.3.jar
spark-forge.jar
step-1.16.4-1.1.0.jar
StorageDrawers-1.16.3-8.3.0.jar
structure_gel-1.16.5-1.7.7.jar
structurize-0.13.208-ALPHA-universal.jar
supermartijn642configlib-1.0.9-mc1.16.jar
supplementaries-1.16.5-0.15.2b.jar
swingthroughgrass-1.16.4-1.5.3.jar
TerraForged-1.16.5-0.2.14.jar
tetra-1.16.5-3.14.1.jar
tetranomicon-1.3.jar
TheAbyss2+1.9.7+1.16.5.jar
the-conjurer-1.16.4-1.0.13.jar
timecontrol-1.16.5-1.1.2.0.jar
titanium-1.16.5-3.2.8.5-19.jar
Titles-1.16.5-3.3.0.jar
Toast-Control-1.16.4-4.3.1.jar
ToolBelt-1.16.5-1.16.0.jar
ToolStats-1.16.5-6.0.1.jar
torchmaster-2.3.8.jar
toughnessbar-6.1.jar
Transport-1.16.5-3.7.0.jar
TrashSlot_1.16.3-12.2.1.jar
twilightforest-1.16.5-4.0.546-universal.jar
upgrade_aquatic-1.16.5-3.1.0.jar
valhelsia_core-16.0.10.jar
valhelsia_structures-1.16.5-0.1.5.jar
valhelsia_tweaks-16.0.8.jar
Vampirism-1.16.5-1.8.0-beta.5.jar
VampirismIntegrations-1.16.5-1.5.1.jar
Waddles-1.16.5-0.8.13.jar
WailaHarvestability-mc1.16.x-forge-1.1.15.jar
walljump-forge-1.16.4-1.3.7.jar
WallpaperCraft-1.16.3-1.4.6.jar
Waystones_1.16.5-7.6.2.jar
Werewolves-1.16.5-1.8-0.5.3.jar
windowlogging-mc1.16.3_v0.0.4.jar
worldedit-mod-7.2.5-dist.jar
Xaeros_Minimap_21.15.1_Forge_1.16.5.jar
XaerosWorldMap_1.16.1_Forge_1.16.5.jar
xercamusic-1.16.5-1.4.jar
YungsApi-1.16.4-Forge-12.jar

BlueAgent commented 3 years ago

I can't say just by looking at the mod list and it'd be too much work to download each mod and try reproduce...

Maybe you could try doing the following steps and letting us know how it goes? Also sending the server log and client log of when you try to do this too.

Start with fresh unmodified configs (+ those mods you have up there).
Spawn in piggy trinket and unlock and equip it.
Modify the server config to disable the piggy trinket.
Check the server logs to make sure that the piggy trinket was disabled after the config reloads.
Open the Trinkets menu and check that the piggy trinket is gone

owmii / Lost-Trinkets

Trinkets usable even after being banned #88