owmii / krate

Krate, better than chest with filters and useful upgrades.
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Item Duplication with Shulker Upgrade #19

Open megagon-extreem opened 2 years ago

megagon-extreem commented 2 years ago

Observed Behavior: If a Krate has the Shulker Upgrade and is broken while the inventory is still open, the items inside can be duplicated

Expected Behavior: The inventory should close then the block is destroyed to prevent this type of dupe glitch

Steps to reproduce:

  1. Place a Krate down.
  2. Ensure the Krate has a Shulker Upgrade and at least 1 item inside
  3. Have the Krate be broken while its inventory is still open a. This was performed with both an Integrated Tunnels Player Simulator, as well as a friend breaking the Krate. b. This will not work with machines like Industrial Foregoing's Block Breaker, as they 'break blocks' by removing it from the world and placing the generic item in their inventory, thereby clearing the item's nbt.
  4. Take the items out of the Krate
  5. Place the Krate back down to find duplicates of the items

Possible Fixes: Most mods deal with this issue by automatically closing the inventory when the block breaks to prevent these exact dupe glitches.

Details: FTB OceanBlock 1.11.0 Krate 0.1.4

Video link: https://drive.google.com/file/d/1AWkjrnXPokCiepLoNtCIeEXHwMDH3Smq/view?usp=sharing