own-pt / cl-wnbrowser

A collaborative editor for OpenWordnet-PT.
http://openwordnet-pt.org
Other
7 stars 8 forks source link

Use HTTP basic authentication #205

Closed hmuniz closed 4 years ago

hmuniz commented 4 years ago

GitHub is deprecating authentication to the GitHub API using query parameters, such as using a access_token query parameter for OAuth user authentication or a client_id/client_secret query parameter for OAuth application authentication. All authentication to the GitHub API should be done using HTTP basic authentication.

See: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

hmuniz commented 4 years ago

ed45aabc61fce36ea0d6746d2020af436206c273 use the Authorization HTTP header instead as using the access_token query parameter as suggested.

arademaker commented 4 years ago

So simple?! Thank you.

hmuniz commented 4 years ago

I think so. If you receive another e-mail about this issue reopen it, please.

arademaker commented 4 years ago

Is it solved and pushed to master?

hmuniz commented 4 years ago

Yes.