Closed arademaker closed 3 years ago
The codecs
directory was removed in some recent updates, but not removed from the setup.py
. I've just removed delphin.codecs
from setup; everything in working well.
pip install .
Processing /Users/ar/hpsg/delphin-rdf
DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default.
pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.
Requirement already satisfied: pydelphin in /Users/ar/venv/lib/python3.8/site-packages (from Delphin-RDF==1.0.0) (1.5.1)
Requirement already satisfied: rdflib in /Users/ar/venv/lib/python3.8/site-packages (from Delphin-RDF==1.0.0) (5.0.0)
Requirement already satisfied: progress==1.5 in /Users/ar/venv/lib/python3.8/site-packages (from pydelphin->Delphin-RDF==1.0.0) (1.5)
Requirement already satisfied: penman==1.1.0 in /Users/ar/venv/lib/python3.8/site-packages (from pydelphin->Delphin-RDF==1.0.0) (1.1.0)
Requirement already satisfied: six in /Users/ar/venv/lib/python3.8/site-packages (from rdflib->Delphin-RDF==1.0.0) (1.16.0)
Requirement already satisfied: isodate in /Users/ar/venv/lib/python3.8/site-packages (from rdflib->Delphin-RDF==1.0.0) (0.6.0)
Requirement already satisfied: pyparsing in /Users/ar/venv/lib/python3.8/site-packages (from rdflib->Delphin-RDF==1.0.0) (2.4.7)
Using legacy 'setup.py install' for Delphin-RDF, since package 'wheel' is not installed.
Installing collected packages: Delphin-RDF
Running setup.py install for Delphin-RDF ... done
Successfully installed Delphin-RDF-1.0.0
The problem was solved by...
There was a reason for this codecs folder; I believe that it was to be formally considered a codecs in PyDelphin standards but I can't remember. We decided to face this problem later, so the branch codecs
was created for that and we removed the folder about it at master to make the repo cleaner. The problem was that we forgot to remove this on the installation file, but @FredsoNerd commit solved that. Installing now is the same way described in the README, pip install /path/to/delphin-rdf
with the optional -e
to install in the developer mode
I see, thank you. But as it is now, are we in a good shape for a first release? If so, should we document what we would need to investigate regarding the codecs? We can open another issue for that and close this one.
I'll close this issue because the installation problem was solved and problem of putting this conversion in the standards of a PyDelphin codecs is a whole different problem and we can create a separate issue for that.
@yfaria can you help?