search

own-pt / glosstag

Semantically Tagged PWN glosses
Other
7 stars 4 forks source link

semi-colon vs colon #34

Open arademaker opened 1 year ago

arademaker commented 1 year ago

we have cases were semi-colon were used instead of colon. The complete list of manually analyzed cases done by the @fcbond team is https://github.com/own-pt/glosstag/blob/master/scripts/issue-34.xml

arademaker commented 1 year ago

@fcbond I converted the issue-34.txt to scripts/issue-34.xml. This is now a valid XML. Maybe you can help me with the not so easy cases? I would be enough to have and extra xxx with the desire fix in each synset. So I do not introduce any error. See the last synset in the file.

note also the comments in my last commit. From your file, I removed the last lines because that error I had already fixed.

------------------------------------------------------------------------
Also:

2. shopping -- (the commodities purchased from stores; "she loaded her shopping into the car"women carrying home shopping didn't give me a second glance")

Finally, the 3 or 4 cases that I manually fixed today I also removed from the scripts/issue-34.xml

fcbond commented 1 year ago

I have added suggestions to all the sentences in https://github.com/own-pt/glosstag/blob/master/scripts/issue-34.xml

I'm going to refer to this issue in Open English Wordnet: the cases @arademaker fixed manually are commit f3bdc6690a84f95c9eb4e4b0be23a7377eabaeca and commit 59ed6d4639bc4925b8c9261d1bccd792a13b4ae6

arademaker commented 1 year ago

Hi @fcbond, maybe you forgot to make a PR or push the commits to GitHub? I can't see the changes.

jmccrae commented 1 year ago

Small comment when implementing this for OEWN. For 11909048-n, the term 'Northern Hemisphere' should be capitalized

erect or climbing herbs of the Northern Hemisphere and southern Africa: bleeding heart, Dutchman's breeches, fumitory, squirrel corn