own-pt / sensetion.el

Emacs word-sense annotation interface
GNU General Public License v3.0
4 stars 2 forks source link

strange case of marks #122

Open arademaker opened 5 years ago

arademaker commented 5 years ago
image

why dark-brown has the superscript JJ1?

arademaker commented 5 years ago

It should be a1 as other single word tokens?

arademaker commented 5 years ago

why MWE does not follow the presentation of single tokens that, once annotated, have the superscript on the right with pos+buffer-sense where buffer-sense is a single-digited sense in the buffer.

odanoburu commented 5 years ago

does https://github.com/own-pt/sensetion.el/commit/3144dc1d8483e6ac4d45b20693a26b63585eb641 fix the problem?

although I made it show s1 as it's an adjective satellite; or do you think we should collapse it to adjective? (I guess annotation-wise it makes more sense, as satellites are not a real PoS..)

why MWE does not follow the presentation of single tokens that, once annotated, have the superscript on the right with pos+buffer-sense where buffer-sense is a single-digited sense in the buffer.

not sure I understand what you mean, but could it be that the problem is that dark brown is a glob, but dark-brown is not?

odanoburu commented 5 years ago

can I close this, @arademaker ?

arademaker commented 5 years ago

No. In the buffer any@dark-brown the superscripts are only numbers. In

(n) anthophyllite | a dark brown mineral of the amphibole group ; magnesium iron silicate ;

the glob drak-brown should have the superscript a1. My point is why dark-brown has superscript s1 (should be a1) but the glob only a number without the PoS?

Yep, our PoS should be only : n, a, r, v

odanoburu commented 5 years ago

this should be fixed now in dev by https://github.com/own-pt/sensetion.el/commit/4b168e24b757e3b61db3bd3bcd6980402daf5d55

arademaker commented 5 years ago

this fixes the code in dev branch, right?

odanoburu commented 5 years ago

fd2f53877e20c4c4317a57f29cc8d8b16273fa61 fixes it in master too.

odanoburu commented 5 years ago