[files_videoviewer] Add option to use video viewer to preview audio files

owncloud-archive / apps

Repo for ownCloud apps. Code here is work in progress and not intended for endusers

373 stars 337 forks source link

[files_videoviewer] Add option to use video viewer to preview audio files #1977

Open stevelong00 opened 9 years ago

stevelong00 commented 9 years ago

While messing around at http://demo.owncloud.org (currently at v7.0) I found that after renaming a .mp3 file to .mp4 and clicking on it the video viewer popped up and started playing the song. It would be nice if there was an option to enable this popup player for audio files in addition to video files, since it doesn't look like there are any other apps that provide a similar inline preview for audio.

ghost commented 9 years ago

@stevelong00 @karlitschek couldn't this be fixed by adding 'audio/mpeg' to the mimetypes on apps / files_videoviewer / js / viewer.js ?

oparoz commented 9 years ago

It works if you also add audio/mp3, but it will conflict with dedicated apps which may do a better job by also showing the picture embedded in the MP3.

ghost commented 9 years ago

i figured, but the music app doesn't come installed by default anymore. so it might confuse some people why their music isn't playing and downloading instead.

PVince81 commented 9 years ago

CC @MorrisJobke author of the music app