owncloud-archive / apps

Repo for ownCloud apps. Code here is work in progress and not intended for endusers
373 stars 337 forks source link

Public link for calendars. #411

Closed Hayholten closed 8 years ago

Hayholten commented 11 years ago

Hello! It seems that with the lastest versions of OwnCloud, the option to get a public link for sharing calendars has disappeared! On olders versions, the option was simply reachable by one click (see picture). How can we get back this precious option? Thanks! 241368test

tanghus commented 11 years ago

We have switched to a common sharing backend which is used for files, calendars, address books etc. Public sharing of other than files is not yet implemented. Didn't we have a thread/issue about that somewhere @georgehrke @MTGap ?

Hayholten commented 11 years ago

Hello! Thanks for reply ;-) Well, you say that the function is not yet implemented. But, by the past, it was (see picture)! Thats why I'm wondering about the fact that it disappeared! I hope that the possiilty to get public link for calendars will come back soon (I need it to embed calendars on a HTML web site). I didn't saw any issues clearly mentioned about it... Thanks ;-)

crti commented 11 years ago

I think a public link is essential for the OC calendar: http://forum.owncloud.org/viewtopic.php?f=3&t=7571

May I also suggest here "privacy options" for (public) calendar sharing (options what to share: date details, times, etc.)

Riparian commented 11 years ago

I fully agree with cri.

RandolfCarter commented 11 years ago

May I also suggest here "privacy options" for (public) calendar sharing (options what to share: date details, times, etc.)

Would you think it sufficient what is implemented with this issue: https://github.com/owncloud/apps/issues/196 ?

crti commented 11 years ago

I'm not an expert of possible CalDAV and iCal (linked, export) tags (Access Class Support), but I think for a first implementation the support for calendar events access class (Public, Private, Confidential, Busy) would be more then welcome and satisfy the needs for publicly shared calendars.

Hayholten commented 11 years ago

Still nothing?

martinpete commented 11 years ago

I think this feature is absolutely essential... are there any news? How about OC 5, will publicly shared calendars be implemented in that major release?

pheraph commented 11 years ago

OC 5 is still missing a function to publicly share calendars. :-|

Hayholten commented 11 years ago

Does anyone have any news about that?

topcyprus commented 11 years ago

fully agried with topic starter

Hayholten commented 11 years ago

;-)

telepath commented 11 years ago

We are working around this with phpicalendar: We cerated a public_user, with whom users can share calendars. Those are scanned and added to phpicalendar by a script. There the calendars are available as public ics. This is VERY inconvenient, so please add this asap!

topcyprus commented 11 years ago

Dear telepath, could you please share an url for your calendar?

Hayholten commented 11 years ago

Hi telepath!

Phpicalendar is no longer supported and developed so how can you take that direction?

vasyugan commented 11 years ago

Hello, I have just been hit by the same limitation. I was trying to migrate a group from Google Calendar to OC, but having a publicly shared calendar is a must. So it seems they are looking for solutions other than OC. (I should mention that the reason for the wish to migrate away from Google is the fact that people feel uncomfortable about it since learning about Prism. It would be a pity if this momentum would be wasted...) So, is anything happening to make this feature available again?

georgehrke commented 11 years ago

So, is anything happening to make this feature available again?

We are working on this in the calendar rework, but we are totally understaffed. I would like to release the calendar rework with ownCloud 6, but if we don't find more developers, I can't promise that the calendar rework will make it into ownCloud 6.

crti commented 11 years ago

I would also like to propose OC again for address and calendar management in an organization, especially like vasyugan said it is a good time, but the missing public link for a calendar is still a major showstopper IMO. When I'm not convinved myself it is difficult to convince others. I would like to help, but have no coding skills. I hope this is seen as an important step by many others and the calendar rework will make it into ownCloud 6. Good coding.

mdamien commented 11 years ago

It seems like this feature was abandonned but it's one hell of a good feature. In my use case, I would like to share my owncloud team calendar with the world and it's overly complicated without this feature. i will publish a patch if I resolve this issue myself

MrCustomizer commented 11 years ago

"We are working on this in the calendar rework, but we are totally understaffed." It does not seem to me, that you are understaffed, it seems to me you set some strange priorities. In the last few days, I have been reading about new features in version 6 like the possibility to upload avatar pictures, an activity feed or a word processor which enables the option to work collaboratively on the same document. Some of these features are probably very time consuming implementation tasks, but in my opinion they are not very useful. I just can't understand how an avatar image or a collaborational word processor (there are already several of these out in the wilderness of the internet) is more important than this feature, which has been abandoned nearly a year ago and which the people obviously miss very much. That's frustrating. I really hope I got the wrong impression and this feature finds it's way in the new release, too. If that's the case, feel free to ignore my rant.

georgehrke commented 11 years ago

We are working on this in the calendar rework, but we are totally understaffed.

It does not seem to me, that you are understaffed, it seems to me you set some strange priorities. In the last few days, I have been reading about new features in version 6 like the possibility to upload avatar pictures, an activity feed or a word processor which enables the option to work collaboratively on the same document. Some of these features are probably very time consuming implementation tasks, but in my opinion they are not very useful. I just can't understand how an avatar image or a collaborational word processor (there are already several of these out in the wilderness of the internet) is more important than this feature, which has been abandoned nearly a year ago and which the people obviously miss very much. That's frustrating. I really hope I got the wrong impression and this feature finds it's way in the new release, too. If that's the case, feel free to ignore my rant.

"we are totally understaffed" is about the calendar app and not ownCloud generally. Not everybody works on every part of ownCloud! And I am still looking for help with the calendar, so it would be more helpful to spread the word that we are looking for developers than to rant about the project.

Thx, Georg

MrCustomizer commented 11 years ago

I'm sorry about my rant, I was getting pretty emotional and I don't have a clue how you are organized internally. Still, I don't get, why manpower is put in these other ownCloud features of the main application, when there are obviously important apps, which are missing developers. Why can't some of these people start working on the calendar app, which in my opinion is a central part of owncloud. But I will stop complaining here, as this bug report is not the right place for such a discussion. Sorry again about my previous post. I shouldn't have posted it here and I should have stayed a bit calmer.

burningTyger commented 11 years ago

Let me chime in, I was going to use owncloud in a larger org but due to the calendar restriction I'll go with Google again. Not that great to be honest but this is a deal breaker for me.

I can fully understand @MrCustomizer when he's wondering why features are being implemented nobody has asked for and nobody would expect. Why not finish up features that are clearly missing? Looks like the Netscape Navigator bug has come to owncloud :)

Anyway, don't think I don't appreciate the work on ownclud. I think it is a very impressive piece of work. This is just some honest user feedback. Thank you.

georgehrke commented 11 years ago

ownCloud is an open source community project. We can kindly ask people to help on certain features, but we can't order them to work on the calendar.

I would also like to see more people working on the calendar. I already asked on my blog, twitter, Facebook and on open source congress/meetings I attended. There isn't much more I can do to get more people to work on the ownCloud calendar...

Please excuse my brevity and typos. Sent from my iPhone

On Oct 26, 2013, at 6:04 PM, burningTyger notifications@github.com wrote:

Let me chime in, I was going to use owncloud in a larger org but due to the calendar restriction I'll go with Google again. Not that great to be honest but this is a deal breaker for me.

I can fully understand @MrCustomizer when he's wondering why features are being implemented nobody has asked for and nobody would expect. Why not finish up features that are clearly missing? Looks like the Netscape Navigator bug has come to owncloud :)

Anyway, don't think I don't appreciate the work on ownclud. I think it is a very impressive piece of work. This is just some honest user feedback. Thank you.

— Reply to this email directly or view it on GitHub.

burningTyger commented 11 years ago

@georgehrke sure and I greatly appreciate your work. And I don't blame you for it. I'm wondering about the direction the project is taking. Why add features that sound totally cool while other places, like calendar, are deserted and left to a single maintainer. Maybe it's not cool or little fun to fix bugs and complete missing features.It just feels like another bloatware project that focuses on more features and less bug fixing.

georgehrke commented 11 years ago

Why add features that sound totally cool while other places, like calendar, are deserted and left to a single maintainer

I couldn't have put it better myself!

MrCustomizer commented 11 years ago

Ok, back on topic: What exactly would one have to do to implement this feature? Earlier in this issue, @tanghus wrote, that this feature disappeared because of a change to a common sharing backend and that this backend currently only supports public sharing of files. Can some of the code for publicly sharing files be reused for calendar sharing? Which part of the source code would be a good starting point for investigating this issue? And what exactly would have to be done to make public calendar sharing possible, again?

Earlier, someone mentioned issue #412. While reading this issue, it appeared to me, that I'm not completely sure, what exactly is meant by public sharing and where are the differences between this issue and #412. Is it correct, that this issue (#411) will be solved as soon as it is possible to share a public ical address and that issue #412 will be solved, as soon as you are able to share a public html page with an embedded calendar? I can't exactly remember, how it was in the past. Did we have both options in the earlier versions of ownCloud or was it only possible to share public ical addresses?

@georgehrke: In issue #412 you wrote, that embedding calendars could probably be implemented pretty easy, as soon as public sharing is available. Could you please elaborate on that thought? Would you create an html page which displays the data from the publicly shared ical address?

MrCustomizer commented 11 years ago

Issue #1147 seems to mention the same problem for the gallery app. Has someone more information concerning my previous post? I asked all these questions, because I'm thinking of looking into this stuff. But I don't have too much time, so it would be nice if someone has some tipps to facilitate my first contact with the code and the app.

georgehrke commented 11 years ago

You would have to implement a public.php like in the files_sharing app. -> see here

For a public link implementation see here

etiess commented 11 years ago

Great Idea @MrCustomizer ! Thank you, and don't hesitate to ask if you want to test it.

rysiekpl commented 10 years ago

@georgehrke so if I wanted to try implementing it, should I start by creating public.php in calendar.app, or by creating calendar_sharing.app from scratch?

rysiekpl commented 10 years ago

And where does public.php get called? Where should I define hooks for the interface -- I'm guessing in the "templates" subdir of calendar app?

georgehrke commented 10 years ago

I would recommend putting public.php in the ajax folder (or in the calendar's root folder). It gets called by ownCloud/public.php. You can register the public.php just like file_sharing does: https://github.com/owncloud/core/blob/master/apps/files_sharing/appinfo/info.xml#L14

georgehrke commented 10 years ago

so if I wanted to try implementing it, should I start by creating public.php in calendar.app, or by creating calendar_sharing.app from scratch?

You should create public.php within the calendar app.

rysiekpl commented 10 years ago

@georgehrke sure, it's in the calendar's main folder. will hack around with it a bit.

rysiekpl commented 10 years ago

@georgehrke okay, so should it be marked as <files>? <webdav> does not make sense, I guess. what needs to be done is publishing iCal feed/file. apart from these two possibilities, is there any other?

georgehrke commented 10 years ago

files / webdav is just the name of the service. you could name it calendar. Then public calendars are accessible thru public.php?service=calendar&t=...

rysiekpl commented 10 years ago

@georgehrke okay, I see there's a share.php doing the same thing for the calendar app: https://github.com/owncloud/calendar/blob/master/appinfo/info.xml#L15

I should hack in it, shouldn't I?

georgehrke commented 10 years ago

I should hack in it, shouldn't I?

Yes. :)

rysiekpl commented 10 years ago

this is odd. there doesn't seem to be any share.php in the calendar app: https://github.com/owncloud/calendar

the rabbit hole gets deeper and deeper.

georgehrke commented 10 years ago

We had to remove share.php when we moved to the common sharing backend. I guess we just forgot to remove the public entry in info.xml

zsi-at commented 10 years ago

@rysiekpl so you are working on this for real? any time schedule or project plan you might want to share? : )

rysiekpl commented 10 years ago

@zsi-at yeah, trying at least; a bit rusty with PHP lately, though. no project plan, seems it should be easy enough. no timeline, too, depends on other things I have to do.

@georgehrke got owncloud running on my dev machine, also got the calendar app in it. created rudimentary share.php; how/where do I get share.js to add the "share link" checkbox in the calendar share dialogue?

rysiekpl commented 10 years ago

@georgehrke I am also not entirely sure what to make of app.php and all these endpoints defined there -- where/how are they being used? what is their relation to what is defined in appinfo/info.xml?

rysiekpl commented 10 years ago

I changed the name of calendar/share.php to calendar/public.php to better match the way files doing public link sharing are named in other apps (e.g. file_sharing app), changed the appropriate lines in appinfo/info.xml - and I still get {"app":"PHP","message":"require_once(): Failed opening required '\/home\/rysiek\/Projekty\/ownCloud\/core\/apps\/calendar\/share.php'

zsi-at commented 10 years ago

@rysiekpl thanks, i appreciate your quick response. it also appears that you made some progress. please keep posting your achievements. maybe others can hook in later to test things ...

georgehrke commented 10 years ago

I changed the name of calendar/share.php to calendar/public.php to better match the way files doing public link sharing are named in other apps (e.g. file_sharing app), changed the appropriate lines in appinfo/info.xml - and I still get {"app":"PHP","message":"require_once(): Failed opening required '\/home\/rysiek\/Projekty\/ownCloud\/core\/apps\/calendar\/share.php'

The public links are stored in the database. You have to increment the calendar version number to trigger an update

rysiekpl commented 10 years ago

@georgehrke you said public calendars are accessible via public.php?service=calendar&t=... - but I am reading the docs and it seems that the URL is /index.php/public/calendar, and that the info.xml should contain share.php

I am at a loss right now. Which is it, then?

rysiekpl commented 10 years ago

@georgehrke ah, thanks. I'll get back to playing with the name of the file in the very end of implementing sharing. first I need to somehow get it to even show up in the share dialogue of a calendar and an event.

rysiekpl commented 10 years ago

Okay, this is getting really frustrating. I added the lib/api.php file, and in appinfo/app.php I added: OC::$CLASSPATH['OCA\Files\Share\Api'] = 'calendar/lib/api.php';

Then, I created appinfo/routes.php and added there:

OC_API::register('get', '/apps/calendar/api/v1/shares', array('\OCA\Calendar\Share\Api', 'getAllShares'), 'calendar');

In lib/api.php I added a stub for getAllShares with just a single line:

OC_Log::write('calendar', __FILE__ . ' : ' . __LINE__ . ' [' . __FUNCTION__ . ']', OC_Log::ERROR);

And did a GET request at: http://owncloud.localhost/index.php/apps/calendar/api/v1/shares

I got a regular Calendar app view, and not a single log entry about the lib/api.php file. I have no idea where to go from here.