search

owncloud-archive / apps

Repo for ownCloud apps. Code here is work in progress and not intended for endusers
373 stars 337 forks source link

Gallery does not display enlarged images #46

Closed ghost closed 11 years ago

ghost commented 12 years ago

This issue is opened following a topic at then owncloud-community forum: http://forum.owncloud.org/viewtopic.php?f=3&t=4623

Since version 4.5.1 the built-in gallery in owncloud does not display the large version of images. Also the slideshow does not work. AFAIR this was no issue in 4.5.0 or before. Thumbnails are displayed ok, but trying to open a thumbnail results in a message displayed: "The requested content cannot be loaded. Please try again later."

Interesting enough large images are displayed ok when opened in the "FILES" section.

Whatsmore: music files seem not to be played ok either.

Specs: uname-a: Linux xx4711 2.6.32-43-server #97-Ubuntu SMP Wed Sep 5 16:56:41 UTC 2012 x86_64 GNU/Linux

johndevs commented 12 years ago

Having the same issues as well :(

pvdh commented 11 years ago

Same with me. System is stock-debian, gallery fails both in chrome and firefox.

Remarkable: according to firefox, whenever I try to see an enlarged picture, 500k to 600k are in fact downloaded to the client. Quite a lot to just show an error-message. ;)

Perhaps owncloud sends the image but the javascript in my browser can't render it?

oszilloskop commented 11 years ago

Same behavior (oc v4.5.0 ok, oc v4.5.1 and 4.5.2 not ok) with my jailbroken AppleTV 2G with iOS-WebStack ( http://goo.gl/LXfUB ):

The cause of the problem is now known to me.

First of all, if the browser have the link to the gallary image already in its cache, the image will shown. Therfore if you would like test the bad behavior, pleace delete your browser cache.

The behavior occurs when you (left-) click on the thumbnail and your PHP have some warnings for you. These warnings are send with the image data to the GUI renderer. But the renderer can't handle these none image data.

It would be great if the owncloud error message would be something clearly.

Please try it with a right click and then open the image in a new browser tab. You will see what is going on.

In my case I got following:

Notice: Undefined variable: save_dir in /private/var/www/owncloud/apps/gallery/lib/photo.php on line 104 Notice: Undefined variable: save_dir in /private/var/www/owncloud/apps/gallery/lib/photo.php on line 105 Warning: mkdir(): Invalid path in /private/var/www/owncloud/apps/gallery/lib/photo.php on line 105 Warning: Cannot modify header information - headers already sent by (output started at /private/var/www/owncloud/apps/gallery/lib/photo.php:104) in /private/var/www/owncloud/lib/response.php on line 24 Warning: Cannot modify header information - headers already sent by (output started at /private/var/www/owncloud/apps/gallery/lib/photo.php:104) in /private/var/www/owncloud/lib/response.php on line 102 Warning: Cannot modify header information - headers already sent by (output started at /private/var/www/owncloud/apps/gallery/lib/photo.php:104) in /private/var/www/owncloud/lib/response.php on line 27 Warning: Cannot modify header information - headers already sent by (output started at /private/var/www/owncloud/apps/gallery/lib/photo.php:104) in /private/var/www/owncloud/lib/image.php on line 164 ÿØÿàJFIFÿþ>CREATOR: gd-jpeg v1.0 (using IJG JPEG v80), default quality ÿÛC    $.' ",#(7),01444'9=82<.342ÿÛC  2!!22222222222222222222222222222222222222222222222222ÿÀ °@"ÿÄ ÿĵ}!1AQa"q2‘¡#B±ÁRÑð$3br‚ %&'()_456789:CDEFGHIJSTUVWXYZcdefghijstuvwxyzƒ„…†‡ˆ‰Š’“”•–—˜™š¢£¤¥¦§¨©ª²³´µ¶·¸¹ºÂÃÄÅÆÇÈÉÊÒÓÔÕÖ×ØÙÚáâãäåæçèéêñòóôõö÷øùúÿÄ ÿĵw!1AQaq"2B‘¡±Á #3RðbrÑ $4á%ñ&'()_56789:CDEFGHIJSTUVWXYZcdefghijstuvwxyz‚ƒ„…†‡ˆ‰Š’“”•–—˜™š¢£¤¥¦§¨©ª²³´µ¶·¸¹ºÂÃÄÅÆÇÈÉÊÒÓÔÕÖ×ØÙÚâãäåæçèéêòóôõö÷øùúÿÚ ?äJg¡ý)EY Ï"Ÿå‚1ŠîçHçåe`ž‚žµXóÀæ”ÇPæ5¸N´ÆϽX)Ö¢~÷¬dÍ’J2k>ápµ£&9õª² úqßÖ’Z•Íc-. †®;úÖµ¾±2®Öbê{£%¾ãÐT FÜ’A=k^HKrUyÃH³i®’aÈü=›œ9#¡¤Ž2áHüóO0žsúT¨F; U·bzt÷¤p#½ \r>œÓ[!¸«±Ä TúûÓ‹ i…‡Ziaž¿0ôïRâ4+7µF[šqÉx¨X0èj\lPòǧZSŒ ...

A bad workaround is: Disable PHP error messages to all site visitors in your PHP.INI

-> display_errors=Off

Don't forget to restart your webserver. Otherwise, the new PHP configuration is not used.

P.S. My forum accounts are overloaded :-) Please can one of you post this information to: http://forum.owncloud.org/viewtopic.php?f=3&t=4623 ?

pvdh commented 11 years ago

Forum has been updated. Setting save_dir to some value like /tmp/oc works as a temporary fix. save_dir is used in function getThumbnail and properly initialized. So "$save_dir = dirname($image_name);" might even be the correct fix.

ivoras commented 11 years ago

$save_dir is never used in getViewImage(), so both lines (104 and 105 in photo.php) should probably be deleted as they seem to be copy-pasted from somewhere else. Unfortunately, the corrupted image file is stored in the browser cache, so the clients need to refresh it before they see the correct image.

oszilloskop commented 11 years ago

I think it is fixed. See #223

ronnietx commented 11 years ago

Did anyone find a fix for this error yet ? ownCloud 4.5.2

The requested content cannot be loaded. Please try again later

DeepDiver1975 commented 11 years ago

@ronnietx fix has just been applied: https://github.com/owncloud/apps/pull/223