Closed LEDfan closed 9 years ago
@jancborchardt @jbtbnl @sorglos how does this looks (note the height + alignment)
And the fix for the alignment in the app-navigation:
Without dividing lines:
Without online state:
Yeah, removing the online state is a good point.
And the dividing lines should go – instead use more vertical whitespace to divide message blocks by different people. Currently it’s the exact same height as the messages themselves and it’s difficult to see where your messages start and the ones of the other person end.
You forgot to increase the height of »Add person« and »View attached files«. They need to be 44px high as well, otherwise it looks very bunched together and is hard to click.
Also, the second line below the username in the left sidebar should show the las message that was written in the chat in half-grey. Can you add that @LEDfan?
Great work! :)
I made the buttons entry 44px height + centered all displaynames left of an avatar:
And the dividing lines should go – instead use more vertical whitespace to divide message blocks by different people. Currently it’s the exact same height as the messages themselves and it’s difficult to see where your messages start and the ones of the other person end.
Also, the second line below the username in the left sidebar should show the las message that was written in the chat in half-grey.
Is this what you mean?
In the last screenshot, there of course shouldn’t be that much padding between different messages of the same person. Otherwise things look fine. :)
@jancborchardt @jbtbnl I think I fixed the margin and height of the messages:
Time is also fixed. Now the time is only shown when it's different than the time of the last msg.
There now is too little vertical padding between the messages of 2 different people. Increase that a bit and we’re good. :)
@jancborchardt
YES! Great stuff @LEDfan :)
Reported by @jancborchardt
Reported by @sorglos