owncloud-archive / chat

GNU Affero General Public License v3.0
38 stars 21 forks source link

Small Design issues #188

Closed LEDfan closed 9 years ago

LEDfan commented 9 years ago

Reported by @jancborchardt

Reported by @sorglos

LEDfan commented 9 years ago
LEDfan commented 9 years ago

@jancborchardt @jbtbnl @sorglos how does this looks (note the height + alignment) screen shot 2014-12-31 at 14 47 30

LEDfan commented 9 years ago

And the fix for the alignment in the app-navigation: screen shot 2014-12-31 at 14 50 37

LEDfan commented 9 years ago

Without dividing lines: screen shot 2014-12-31 at 14 53 23

LEDfan commented 9 years ago

Without online state: screen shot 2014-12-31 at 14 56 06

jancborchardt commented 9 years ago

Yeah, removing the online state is a good point.

And the dividing lines should go – instead use more vertical whitespace to divide message blocks by different people. Currently it’s the exact same height as the messages themselves and it’s difficult to see where your messages start and the ones of the other person end.

You forgot to increase the height of »Add person« and »View attached files«. They need to be 44px high as well, otherwise it looks very bunched together and is hard to click.

Also, the second line below the username in the left sidebar should show the las message that was written in the chat in half-grey. Can you add that @LEDfan?

Great work! :)

LEDfan commented 9 years ago

I made the buttons entry 44px height + centered all displaynames left of an avatar: screen shot 2015-01-10 at 07 57 09

LEDfan commented 9 years ago

And the dividing lines should go – instead use more vertical whitespace to divide message blocks by different people. Currently it’s the exact same height as the messages themselves and it’s difficult to see where your messages start and the ones of the other person end.

Also, the second line below the username in the left sidebar should show the las message that was written in the chat in half-grey.

Is this what you mean? screen shot 2015-01-10 at 08 08 27

jancborchardt commented 9 years ago

In the last screenshot, there of course shouldn’t be that much padding between different messages of the same person. Otherwise things look fine. :)

LEDfan commented 9 years ago

@jancborchardt @jbtbnl I think I fixed the margin and height of the messages: schermafbeelding 2015-02-02 op 13 04 13

LEDfan commented 9 years ago

Time is also fixed. Now the time is only shown when it's different than the time of the last msg. schermafbeelding 2015-02-02 op 13 09 14

jancborchardt commented 9 years ago

There now is too little vertical padding between the messages of 2 different people. Increase that a bit and we’re good. :)

LEDfan commented 9 years ago

schermafbeelding 2015-02-09 op 17 40 52 @jancborchardt

jancborchardt commented 9 years ago

YES! Great stuff @LEDfan :)