search

owncloud-archive / disableunsharing

⛓️ Prevents users from unsharing folders shared by admins
GNU Affero General Public License v3.0
1 stars 1 forks source link

config parameter `disableunsharing` needs documentation in config.sample.php #4

Open mmattel opened 6 years ago

mmattel commented 6 years ago

As shown in README.md the new config parameter disableunsharing (or however it will be called) needs documentation in config.sample.php

@butonic

patrickjahns commented 6 years ago

@mmattel from my point of view - the config.sample.php should only contain information for default applications shipped with ownCloud - not for all possible apps that might be around

mmattel commented 6 years ago

fair point. then we need to consider a mechanism how we can address this as this is a general point. not including foreign apps, but apps available from ownCloud not beeing part of core. else this gets immediately forgotten...

adding @settermjd

settermjd commented 6 years ago

Sounds like a fair call to me. However, is the term "apps" being used interchangeably with "settings" in this thread? I'm just a little confused.

patrickjahns commented 6 years ago

apps / applications = ownCloud server applications (i.e. gallery, templateeditor etc. )

Any of these apps might have they own system settings ( which will be written in config.php ). If an app is not shipped by default with a release - it might be confusing to have an config.php option in the sample file, that might not have any affect as the related app is not installed.

Hence the request to not document the settings for this app in config.sample.php.

Further thoughts/comments?

mmattel commented 6 years ago

Clear statement, to have the same terminology for future use I propose:

mmattel commented 6 years ago

This differenciation is btw true not only for config.sample.php, but also for ./occ commands !

PVince81 commented 6 years ago

Tbh I'd prefer have this being a core feature as part of files_sharing or the core sharing component. And the setting would then be a visible checkbox in the sharing settings section instead. This in the longer term.

@pmaier1

pmaier1 commented 6 years ago

This is not an official feature yet. Therefore other issues have higher priority for the docs. If somebody wants to use it, the README gives sufficient information.

Tbh I'd prefer have this being a core feature as part of files_sharing or the core sharing component.

Yes, I fully agree. Checkbox and option to specify groups to disable unsharing for.