search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Added GPS position with leaflet-gps plugin #10

Closed PVince81 closed 10 years ago

PVince81 commented 10 years ago

Added leaflet-gps layer for GPS position: https://github.com/stefanocudini/leaflet-gps

The original source code of the library needed to be split into separate folders for ownCloud to be able to load them.

jancborchardt commented 10 years ago

@brantje can you check this out?

@PVince81 this needs rebasing. :)

brantje commented 10 years ago

Afaik we already load the current GPS location. But this solution seems neat to me =). Will check it out asap.

PVince81 commented 10 years ago

Possibly but I find having that button to center on the current position to be neat. In the previous version it always showed me some place in the USA, never my current position.

PVince81 commented 10 years ago

Ok, rebased.

Now I see that you already added GPS support after I submit my PR :smile: Up to you to decide whether you want that extra layer or not.

I find it nice to have a button I can click to recenter on the current position.

jancborchardt commented 10 years ago

What would be really cool is also to cache that location for further loads instead of always starting out in Denver. Automatically get to the location instead of needing to press a button. See #7

brantje commented 10 years ago

Fixed with 963a89174ef565f6033779ee84ce235aadc0adab

jancborchardt commented 10 years ago

@brantje when closing pull requests, please make sure to press the »Delete branch« button here as well. :)