owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Lots of layout improvements #101

Closed jancborchardt closed 8 years ago

jancborchardt commented 8 years ago

Please review @v1r0x

v1r0x commented 8 years ago

Nice work! I think we shouldn't close the side panel after the user clicks on a list item. Especially if the user clicks the contact layer the progress isn't visible. Rather it should close on a click on the map.

jancborchardt commented 8 years ago

True, at least on the desktop. There it should also not close on click on the map I think – only the menu toggle should do that.

jancborchardt commented 8 years ago

Can you maybe tweak the JS for that? Not sure I’m proficient enough to do that. :D

v1r0x commented 8 years ago

Can you maybe tweak the JS for that? Not sure I’m proficient enough to do that. :D

Tomorrow. Shouldn't commit something at around 4am ;) I'll have a look at gmaps and take a look at their side panel.

v1r0x commented 8 years ago

Couldn't find something in the code. Also I resized the browser window on master branch to force mobile css and then there it didn't closed the nav bar. Don't know what's going on..

jancborchardt commented 8 years ago

Let’s merge it for now and improve going forward. :)

Henni commented 8 years ago

@jancborchardt didn't you or me create an issue for the hidden sidebar on desktop in the core repo? Do you remember if and where? If not we should do so as I think other apps might also like this functionality.

jancborchardt commented 8 years ago

Yeah, I think it might have been in the Calendar repo. Either way I would say we shouod experiment with it here first. Then check if it also works for Calendar, and then we could move it to core.

Henni commented 8 years ago

@jancborchardt sounds good to me :+1: